[#45821] - [5.4] Fix unlocked and possibly uninstalled core plugins for new installs and updates
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 45821
- Diff
- richard67:5.4-dev-fix-unlocked-core-extensions-2025-08-02
User tests: Successful: Unsuccessful:
Pull Request for Issue #45816 (Joomla 5 part).
Summary of Changes
On new installations of Joomla 5 or 6 and updates sites of these versions, the following core plugins are not locked like all core extensions should be:
- plg_schemaorg_article
- plg_schemaorg_blogposting
- plg_schemaorg_book
- plg_schemaorg_event
- plg_schemaorg_jobposting
- plg_schemaorg_organization
- plg_schemaorg_person
- plg_schemaorg_recipe
- plg_schemaorg_custom
- plg_system_schemaorg
- plg_task_globalcheckin
This pull request (PR) updates the base.sql installation SQL scripts to fix that for new installations.
In addition, it adds new update SQL scripts 5.4.0-2025-08-02.sql to fix it when updating from any previous 5.x version to 5.4.
The same new update SQL script also adds back the plugins to the extensions table with disabled state when updating in case if they have been uninstalled, but only then.
Finally, it changes the insert statements in the present update SQL scripts where the particular plugins were added to insert them with the right lockedvalue.
The latter would not really be necessary as the previously mentioned new update SQL script will fix it anyway.
But as the present update SQL scripts might server as templates for future PRs to add new plugins, the issue might come back, so I've decided to fix them, too.
Of course I have done that with a comment with reference to this PR.
In 6.0-dev the issue with be fixed for updates with my PR #45822 by providing a new 6.0.0-*.sql update SQL script.
For new installations it will be fixed in 6.0-dev when this PR has been merged into 5.4-dev and then merged up into 6.0-dev.
Testing Instructions
New installation
For the actual result, have an installation of the current 5.4-dev branch or the latest 5.4 nightly build or a 5.4.0-alpha3.
For the expected result, either make a new installation with the patched installation package created by Drone for this PR, or apply this PR with patchtester on the site used for the actual result, delete all database tables in your database and remove the configuration.phpfile and make a new installation.
Then check with a database client like e.g. phpMyAdmin for extensions which are not locked:
SELECT `type`, `name` FROM `#__extensions` WHERE `locked` <> 1;
On a clean new installation there should not be any non-core extensions.
On a real site, only non-core extensions should be listed.
Update with unlocked plugins being present
Have an installation of 5.4.0-alpha3 or any older 5.x version.
For the actual result, update that site to the latest 5.4-dev nightly build.
- Custom URL for live update:
https://update.joomla.org/core/nightlies/next_minor_list.xml - Update package download for upload & update:
https://developer.joomla.org/nightlies/Joomla_5.4.0-alpha4-dev-Development-Update_Package.zip
But you can skip the test of the actual result as we already know it has the issue.
For the expected result, update that 5.4.0-alpha3 or older site to the custom update URL or the patched update package created by Drone for this PR.
- Custom URL for live update:
https://artifacts.joomla.org/drone/joomla/joomla-cms/5.4-dev/45821/downloads/86715/pr_list.xml - Update package download for upload & update:
https://artifacts.joomla.org/drone/joomla/joomla-cms/5.4-dev/45821/downloads/86715/Joomla_5.4.0-alpha4-dev+pr.45821-Development-Update_Package.zip
Then do the same SQL check as described at the end of the previous test "New installation".
Update with unlocked plugins having been uninstalled
Same procedure as the previous update test, but this time uninstall some or all of the plugins before doing the update.
Actual result BEFORE applying this Pull Request
See issue #45816 and list of plugins at the top of the description of this PR.
Expected result AFTER applying this Pull Request
No unlocked core extensions can be found.
If the plugins handled by this PR have been uninstalled before the update, they are added back again with disabled state with the update.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql Installation |
| Labels |
Added:
PR-5.4-dev
|
||
| Labels |
Added:
bug
|
||
| Title |
|
||||||
I have tested this item ✅ successfully on 2a914d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45821.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45821.
Final test before merge with JBT recreate/graft for new installations and by manual file upload update
- Checked with SQL statement before for updates and after each time
- Checked
administrator/logs/joomla_update.phpfile after updates - mariadb
- Using SQL statement e.g. for 50
docker exec jbt-madb bash -c "mariadb -u root -proot test_joomla_50 -e 'SELECT \`type\`, \`name\` FROM \`jos50_extensions\` WHERE \`locked\` <> 1;'" - Update from 5.0.0, 5.1.0 and 5.4.0-alpha3
- New installation
- Using SQL statement e.g. for 50
- postgresql
- e.g. for 50
docker exec jbt-pg bash -c "psql -U root -d test_joomla_50 -c 'SELECT type, name FROM jos50_extensions WHERE locked <> 1;'" - Update from 5.0.0, 5.1.0 and 5.4.0-alpha3
- New installation
- e.g. for 50
🤔 The plugin plg_sampledata_testing remains only from mariadb and only from 5.1.0 and 5.4.0-alpha3 (looks like not installed with PostgreSQL and 5.0.0) -> to be discussed in maintainer meeting.
| Labels |
Added:
RTC
RMDQ
|
||
🤔 The plugin
plg_sampledata_testingremains only from mariadb and only from 5.1.0 and 5.4.0-alpha3 (looks like not installed with PostgreSQL and 5.0.0) -> to be discussed in maintainer meeting.
@muhme The TESTING sampledata plugin is a special thing which is only available on development environments, e.g. git clones or nightly builds, but not in release builds. Therefore it is not counted as core extension. We should ignore that for now regarding this PR.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as the PR has received changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45821.
| Title |
|
||||||
| Labels |
Removed:
RTC
RMDQ
|
||
I have tested this item ✅ successfully on 6af80bf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45821.
I have tested this item ✅ successfully on 6af80bf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45821.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45821.
Thanks guys for testing. You are the best.
I have tested this item ✅ successfully on 2a914d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45821.