[#45808] - [6.0] Convert Popular Module to Service
- Fixed in Code Base
- 31 Jul 2025
- Medium
- Build: 6.0-dev
- # 45808
- Diff
- rdeutz:conv-service-mod-popular
User tests: Successful: Unsuccessful:
Summary of Changes
We want to get rid of static helpers and the use super globals, this module is one of the latest modules working in the old way. The PR converts it (leaving the dark side).
Testing Instructions
Check if the module is behaving in the same way as it was before the PR
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
PR-6.0-dev
|
||
I have tested this item ✅ successfully on 0966f7e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45808.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45808.
Please deprecate the unused language string MOD_POPULAR_NO_MATCHING_RESULTS
| Category | Modules Administration | ⇒ | Administration Language & Strings Modules |
Please deprecate the unused language string MOD_POPULAR_NO_MATCHING_RESULTS
done, fun part it was never used.
| Status | Pending | ⇒ | Ready to Commit |
RTC state still valid
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45808.
as the modules are misusing the emtpystate
I would agree to that statement, but I don't want to pull that problem into the scope of this PR.
thats why i created a new issue
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-31 13:56:51 |
| Closed_By | ⇒ | softforge | |
| Labels |
Added:
RTC
Language Change
|
||
Thanks to all who worked on this PR, your work is appreciated
I have tested this item ✅ successfully on 0966f7e
I have successfully tested this PR. Thanks @rdeutz!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45808.