[#45785] - [5.4] naming convention language string
- Fixed in Code Base
- 26 Jul 2025
- Medium
- Build: 5.4-dev
- # 45785
- Diff
- hans2103:5.4-naming-convention-language-string
User tests: Successful: Unsuccessful:
Pull Request for no existing Issue .
Summary of Changes
Two language strings for a description use DESCR.
All other use DESCRIPTION or DESC.
We should not have a third flavor.
Therefor this PR will change the language string from _DESCR to _DESC
This PR will require a change in all languages.
Testing Instructions
- Joomla Administrator > System > Plugins > Editor - Codemirror
- open plugin to edit
- go to tab advanced
- press green button to add custom extensions
- read the description below both input fields
Actual result BEFORE applying this Pull Request
There is a description between both input fields
Expected result AFTER applying this Pull Request
The description is still there and the same.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
@hans2103 You cannot just remove a language key (changing a key is like removing the old key and adding the new key).
You have to deprecate the language string for 6.0, and when this PR got merged and merged up into 6.0-dev, someone has to make a PR for 6.0-dev to finally remove the deprecated string.
You can find examples for this here:
The changes in the spell check GitHub action would not be needed as your PR does not handle language stings with spelling errors in the key.
| Labels |
Added:
Language Change
Updates Requested
PR-5.4-dev
|
||
@brianteeman @richard67 thank you for the clear explanation.
Used your feedback and adjusted the PR based on the way Brian created his in https://github.com/joomla/joomla-cms/pull/45725/files
I have tested this item ✅ successfully on bf1a180
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45785.
I have tested this item ✅ successfully on bf1a180
I have successfully tested this. Thanks.@hans2013
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45785.
| Labels |
Removed:
Updates Requested
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45785.
| Labels |
Added:
RTC
|
||
Final check before merge: Each language key is only used once and this usage has been changed. Old language keys are still existing and marked as deprecated in 6.0.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-26 14:46:25 |
| Closed_By | ⇒ | muhme |
Thank you @hans2103 for your contribution. Thank you @brianteeman and @exlemor for testing.
You can't change it this way. You need to deprecate the existing string and add a new one. See #45725 for an example