User tests: Successful: Unsuccessful:
$limitstart is passed as the second parameter to array_slice(). If $limitstart is null, it triggers the deprecation warning because array_slice() expects an integer for $offset.
npx cypress run --spec '.\tests\System\integration\administrator\components\com_installer\'
check php error_log
PHP Deprecated: array_slice(): Passing null to parameter #2 ($offset) of type int is deprecated in administrator\components\com_installer\src\Model\InstallerModel.php on line 129
this deprecated entry in the logs is resolved
note: there are other deprecation notices about tobscure see joomla-backports/json-api-php#4
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_installer |
Haven't worked with Cypres before and I get the followig
@hans2103 Thank you for trying to run Cypress-based System Tests 🚀
npx cypress run --spec 'tests/System/integration/administrator/components/com_installer/*.cy.js'
PHP Deprecated: array_slice()
entries in my PHP error_log, but I do not see PHP Deprecated: array_slice()
from running these two System Tests specificationsLog Deprecated API
, but do not see any array_slice
deprecation messages in administrator/logs/deprecated.php
file@brianteeman Could you please adjust/extend the test description?
No idea why you dont see the php error log entries - you should check your php logging and error reporting settings
This was deprecated in php 8.1 https://www.php.net/manual/en/migration81.deprecated.php
You wont see them in the Log Deprecated API log as that is for Joomla deprecations NOT php deprecations
I have been testing this PR and I get four tests passed.
Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ FromUrl.cy.js 00:12 2 2 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ Languages.cy.js 00:02 2 2 - - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! 00:14 4 4 - - -
However, there is no php error log created. I have tried with php8.3 and php8.4. I know this is something to do with my Apache/PHP installation on Mac but I do not know what. Thinking...
However, there is no php error log created.
for my local installation it is:
macOS $ php -i | grep error_log
error_log => /usr/local/var/log/php_errors.log => /usr/local/var/log/php_errors.log
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
PR-5.4-dev
|
Setting RTC as we have 2 approvals by experienced maintainers, and it is a no-brainer.
Labels |
Added:
RTC
|
Final test before merge:
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-05 10:13:14 |
Closed_By | ⇒ | muhme |
Thank you @brianteeman for your contribution. Thank you @richard67, @hans2103, @ceford and @rdeutz for supporting this PR.
@brianteeman sorry... Not able to test this.
Haven't worked with Cypres before and I get the followig