RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomlaweby
joomlaweby
24 Jul 2025

Summary of Changes

Converts the who is online site module to service provider.

Testing Instructions

  1. Make sure you have site module mod_whosonline published
  2. You should see module output
mod_whosonline

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomlaweby joomlaweby - open - 24 Jul 2025
avatar joomlaweby joomlaweby - change - 24 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2025
Category Modules Front End
avatar ghazal ghazal - test_item - 25 Jul 2025 - Tested successfully
avatar ghazal
ghazal - comment - 25 Jul 2025

I have tested this item ✅ successfully on 886678d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775.

avatar hans2103 hans2103 - test_item - 25 Jul 2025 - Tested successfully
avatar hans2103
hans2103 - comment - 25 Jul 2025

I have tested this item ✅ successfully on 886678d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775.

avatar hans2103 hans2103 - test_item - 25 Jul 2025 - Tested successfully
avatar hans2103 hans2103 - test_item - 25 Jul 2025 - Tested successfully
avatar exlemor exlemor - test_item - 25 Jul 2025 - Tested successfully
avatar exlemor
exlemor - comment - 25 Jul 2025

I have tested this item ✅ successfully on 886678d

I have successfully tested this on Chrome, Firefox, Safari.

(Unrelated to this PR but Heiko and I discovered a potential bug or at least odd behavior in Safari 18.x+ with the Who's Online module (with or without the PR applied) where if you reload the front-end page it increments by 1 the number of Who's Online guests even though there is still just you browsing the site - it may be because of a protective feature of Safari..)

Interestingly, (I checked the database) while the session_id is different each time the 820 byte data that is in the data field is IDENTICAL.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775.

avatar richard67 richard67 - change - 25 Jul 2025
Status Pending Ready to Commit
Labels Added: PR-5.4-dev
avatar richard67
richard67 - comment - 25 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775.

avatar muhme
muhme - comment - 26 Jul 2025

Final test before merge, before applying this PR, with JBT graft Joomla_5.4.0-alpha4-dev-Development-Full_Package.zip:

  • Tested to display '# of Guests / Users', 'Usernames' and 'Both'

Tested with this PR by graft Joomla_5.4.0-alpha4-dev+pr.45775-Development-Full_Package.zip:

  • ✅ Tested to display '# of Guests / Users', 'Usernames' (with no one logged in -> empty and one login) and 'Both'
  • Installed German language paket as extension and switched to default German
  • ✅ Tested to display Who's Online with German translations
avatar muhme muhme - change - 26 Jul 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-07-26 10:08:21
Closed_By muhme
Labels Added: RTC
avatar muhme muhme - close - 26 Jul 2025
avatar muhme muhme - merge - 26 Jul 2025
avatar muhme
muhme - comment - 26 Jul 2025

Thank you @joomlaweby for your contribution. Thank you @ghazal, @hans2103 and @exlemor for testing.

Add a Comment

Login with GitHub to post a comment