? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
12 Oct 2014

Move modals from mootools to Bootstrap

FINAL PR to get all back end using bootstrap modals. The rest are: #4513 #4514 #4561 #4562 and #4563

Testing:
You need a multilingual site
After Applying this patch

Try the button on the sticky bar at the footer (first icon from left to right)


screenshot 2014-10-12 11 13 44
screenshot 2014-10-12 11 09 44

avatar dgt41 dgt41 - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Oct 2014
Category Templates (admin) UI/UX
avatar dgt41 dgt41 - change - 14 Oct 2014
The description was changed
avatar nicksavov nicksavov - change - 16 Oct 2014
The description was changed
Labels Added: ?
avatar tairedweb tairedweb - test_item - 17 Oct 2014 - Tested successfully
avatar tairedweb
tairedweb - comment - 17 Oct 2014

@success +1

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4575.

avatar suredweb
suredweb - comment - 17 Oct 2014

@Test It work

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4575.

avatar suredweb suredweb - test_item - 17 Oct 2014 - Tested successfully
avatar losedk
losedk - comment - 17 Oct 2014

Tested. The modal is way to big :)

skaermbillede 2014-10-17 kl 15 28 29

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending Needs Review
avatar dgt41
dgt41 - comment - 6 Nov 2014

Hathor view:
screen shot 2014-11-06 at 10 26 34

avatar infograf768
infograf768 - comment - 7 Nov 2014

@test
OK here. That is if I do not reduce the screen to a phone size as the modal disapears in that case

avatar dgt41
dgt41 - comment - 7 Nov 2014

@infograf768 the problem is that status bar becomes hidden on mobile view and all the modal code will vanish due to that hidden-phone class. Also this will appear only in desktop when resizing the window to less than 380px.

<div id="status" class="navbar navbar-fixed-bottom hidden-phoneā€¯>

Moving it away from status bar the problem vanish and is the best way to solve this...

avatar infograf768
infograf768 - comment - 7 Nov 2014

Have I told you I hate this status bar (compared to 2.5) ? :)

avatar dgt41
dgt41 - comment - 7 Nov 2014

@infograf768 Agree :100:

avatar infograf768
infograf768 - comment - 7 Nov 2014

OK for me. One more tester

avatar dgt41
dgt41 - comment - 23 Nov 2014

I strongly recommend that #3918 gets merged before this one!

1739e1e 1 Dec 2014 avatar dgt41 CSS
avatar smanzi
smanzi - comment - 7 Dec 2014

@test success

Tested without #5087
without 5087

... and with #5087
with 5087

(the modals are equals, pixel by pixel)

avatar smanzi smanzi - test_item - 7 Dec 2014 - Tested successfully
avatar wilsonge wilsonge - close - 28 Dec 2014
avatar wilsonge wilsonge - change - 28 Dec 2014
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2014-12-28 02:52:19
avatar wilsonge
wilsonge - comment - 28 Dec 2014

Two good tests here now (all-be-it one quite old). So merging. Thanks guys!

avatar 810
810 - comment - 20 Jan 2015

the modal width and position, is now breaking modals. see kunena installer:
modal

avatar dgt41
dgt41 - comment - 20 Jan 2015

@810 what are the iframe dimensions?

avatar 810
810 - comment - 20 Jan 2015

before

div.modal.fade.in {
    top: 10%;
}
div.modal {
   width:580px;
}

Now

div.modal.fade.in {
    top: 5%;
}
div.modal {
   width: 80%
}
avatar dgt41
dgt41 - comment - 20 Jan 2015

@810 Will come up with some code (less) tomorrow

avatar 810
810 - comment - 20 Jan 2015

ok thanx

Add a Comment

Login with GitHub to post a comment