[#45744] - [6.0] Tag search for mod-finder
- Fixed in Code Base
- 18 Jul 2025
- Medium
- Build: 6.0-dev
- # 45744
- Diff
- chmst:60-mod-finder-search-tag
User tests: Successful: Unsuccessful:
Pull Request for Issue #41304 .
Summary of Changes
Improve a11y for mod finder using the search tag and remove role="search".
Testing Instructions
The mod_finder module works exactly the same way before and after patch.
Actual result BEFORE applying this Pull Request
<form class="mod-finder js-finder-searchform form-search" action="<?php echo Route::_($route); ?>" method="get" role="search">
..
</form>
Expected result AFTER applying this Pull Request
The role="search" is removed and a tag added.
<search>
<form class="mod-finder js-finder-searchform form-search" action="<?php echo Route::_($route); ?>" method="get" aria-label="search">
...
</form>
</search>
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[x No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I started to write that this PR is not correct because you can set the search in the module tag but then I saw it was missing from there.
Shouldnt search be added to the module tags and then set as the default for the search module?
In my solution, all existing modules would have the search tag after Joomla update.
If here is no Override of the mod_finder.
But for new sites, your solution is good. Maybe we can make a update script for #__extensions.
In my solution, all existing modules would have the search tag after Joomla update. If here is no Override of the mod_finder.
Or if the template did not already wrap the module with the search tag which would produce a search element inside a search element
search is a relatively new element and it is correct to use it. I am not however in favour of changing existing sites markup and the method used here does that. We should be using the module tag for this
I'm not 100% certain that the markup this will produce is correct anyway. Search should be a container element. But with this PR the container is still a div (or any other module tag) with search as another container inside that container. https://en.wikipedia.org/wiki/Matryoshka_doll
I have tested this item ✅ successfully on a3da311
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45744.
could you add that the role=search is removed as not required in the PR description please for future reference
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45744.
Thank you for testing and your opinion. When testing ith AXE it is correct - one error less.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-6.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45744.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-18 17:51:51 |
| Closed_By | ⇒ | softforge |
Thank you to all involved in testing and contributing.
I have tested this item ✅ successfully on a3da311
6.0.0-alpha2-dev
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45744.