[#45729] - [5.4] typos.toml
- Fixed in Code Base
- 15 Jul 2025
- Medium
- Build: 5.4-dev
- # 45729
- Diff
- brianteeman:typos-document
User tests: Successful: Unsuccessful:
This pr sorts and explains the exceptions used by the typos action
(it also removes a few that were fixed upstream and I hadn't noticed)
code review @richard67
do the comments make sense?
should it be tab or space aligned? changed to spaces
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
Happy to change to spaces if you prefer
Let's see what other reviewers will say.
Maybe you can add some testing instructions (just review) or remove my name from the instruction to review so we get other reviewers, too? Right now readers would think the PR is just for me, and only I shall review. But I'd like to stick with the rules and have 2 successful tests (or reviews) for RTC.
P.S.: Of course spaces would look nicer if all comments were aligned, but that would mean whenever you add a very long sting, you have to add spaces to all the others.
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 57b6408
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45729.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45729.
requestor and rgba are removed from the list.
yes they have been added upstream since I made the list originally so we no longer need to have the exceptions
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-15 12:03:01 |
| Closed_By | ⇒ | muhme | |
| Labels |
Added:
RTC
|
||
Thanks
Thank you @brianteeman and @richard67.
I have tested this item ✅ successfully on b405c1a
Reviewed with success.
The comments are correct.
The GitHub action is still successful.
The file might look not nice with the tabs depending on editor settings, but I don't think we should make it look nicer by using spaces and aligning the comments.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45729.