@Hackwar I've allowed myself to update your PR to the base branch and resolved the conflicts so that this PR gets all the composer dependency updates from the upmerged 5.4-dev composer update but keeps the updates made by your PR, so all changes made with your PR are preserved, nothing got lost.
There is one questionable change where you reset the $cookieName and not the $oldCookieName for which I have left a review comment. That could possibly be a copy paste from the refactoring of that method call, which happened in parallel in this PR here and in 5.4-dev (which was merged up into 6.0-dev).
I have not touched the PHPstan baseline file. Currently we have 13 new errors which all come from the deprecation of the Joomla\String\Inflector class.
joomla-cms-bot
- 
@Hackwar I've allowed myself to update your PR to the base branch and resolved the conflicts so that this PR gets all the composer dependency updates from the upmerged 5.4-dev composer update but keeps the updates made by your PR, so all changes made with your PR are preserved, nothing got lost.
There is one questionable change where you reset the
$cookieNameand not the$oldCookieNamefor which I have left a review comment. That could possibly be a copy paste from the refactoring of that method call, which happened in parallel in this PR here and in 5.4-dev (which was merged up into 6.0-dev).I have not touched the PHPstan baseline file. Currently we have 13 new errors which all come from the deprecation of the
Joomla\String\Inflectorclass.