[#45720] - [5.3] Fix schema.org with invalid breadcrumb json-ld
- Fixed in Code Base
- 10 Aug 2025
- Medium
- Build: 5.3-dev
- # 45720
- Diff
- bembelimen:5.3/schema-listitem
User tests: Successful: Unsuccessful:
Alternative for #45316
Summary of Changes
This PR is a alternative fix for #45277 where the connection is improved instead of deleted.
Testing Instructions
- Apply patch
- Activate a breadcrumb module either on "none" or a non-existing position on your site
Actual result BEFORE applying this Pull Request
- Google reports invalid JSON-data
Expected result AFTER applying this Pull Request
- JSON data is valid
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
bug
PR-5.3-dev
|
||
| Category | Front End Plugins | ⇒ | Modules Front End Plugins |
I modified this PR, so it checks if the mod_breadcrumbs (which actually has a wrong spelling, should be without s) has injected the BreadcrumbList ld+json schema into the webasset manager and take the id from this json.
Also I renamed the webasset name since it's bind to the module which actually only one breadcrumb should be allowed on the page for ld+json and not only be filled by our module, also 3rd party should be allowed to add a breadcrumb schema and be linked in the schemaorg plugin.
As b/c fall back the old module asset name is also checked, the reason for this is that the ld+json schema is created in the layout of the module and can be overridden. Which is the wrong place but this is another story and should be fixed in another PR.
I have tested this item ✅ successfully on 982cdc3
Now it works for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45720.
The renaming from mod_breadcrums to mod_breadcrumb is not everywhere. Only in comment and message text, no consequeces for the code, but should be consistent.
I have tested this item ✅ successfully on ee1b5ea
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45720.
@bembelimen How can I reproduce the error to verify the patch?
Ho do I make Google complain. Is the module is set to position none, will there be any output?
Ho do I make Google complain. Is the module is set to position none, will there be any output?
Every JSON+LD entry from Joomla! has an unique ID. You can observe the error, if you check the source code of the web page. You'll see two JSON+LD (if breadcrumbs are visible) while the main one is refering to the breadcrumb one.
If breadcrumbs are not generated (or two are available) you'll see that the referenced ID is wrong,
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-10 16:04:03 |
| Closed_By | ⇒ | bembelimen |
I have tested this item 🔴 unsuccessfully on 5715410
Using this PR removes the link to the breadcrumbs json+ld entry if your template uses dynamic module positions which are not listed in the xml. Which removes the entry on my site because I use the breadcrumbs position from cassiopeia without defining it my self.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45720.