User tests: Successful: Unsuccessful:
Alternative for #45316
This PR is a alternative fix for #45277 where the connection is improved instead of deleted.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Labels |
Added:
bug
PR-5.3-dev
|
Category | Front End Plugins | ⇒ | Modules Front End Plugins |
I modified this PR, so it checks if the mod_breadcrumbs (which actually has a wrong spelling, should be without s) has injected the BreadcrumbList ld+json schema into the webasset manager and take the id from this json.
Also I renamed the webasset name since it's bind to the module which actually only one breadcrumb should be allowed on the page for ld+json and not only be filled by our module, also 3rd party should be allowed to add a breadcrumb schema and be linked in the schemaorg plugin.
As b/c fall back the old module asset name is also checked, the reason for this is that the ld+json schema is created in the layout of the module and can be overridden. Which is the wrong place but this is another story and should be fixed in another PR.
I have tested this item ✅ successfully on 982cdc3
Now it works for me.
I have tested this item 🔴 unsuccessfully on 5715410
Using this PR removes the link to the breadcrumbs json+ld entry if your template uses dynamic module positions which are not listed in the xml. Which removes the entry on my site because I use the breadcrumbs position from cassiopeia without defining it my self.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45720.