[#45691] - [6.0] [com_actionlogs] reduce-deprecations
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 45691
- Diff
- alikon:patch-20
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
reduce the number of deprecations
Testing Instructions
Actionlogs works as usual
Actual result BEFORE applying this Pull Request
Deprecations
Expected result AFTER applying this Pull Request
Less deprecations
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
PR-5.4-dev
|
||
| Title |
|
||||||
| Category | Administration | ⇒ | Administration JavaScript Unit Tests |
| Labels |
Added:
Unit/System Tests
|
||
| Title |
|
||||||
| Labels |
Added:
PR-6.0-dev
Removed: PR-5.4-dev |
||
| Labels |
Added:
bug
|
||
HLeithner
- | Title |
|
||||||
| Category | Administration JavaScript Unit Tests | ⇒ | Administration |
| Labels |
Removed:
Unit/System Tests
|
||
@alikon 🥰 love the incredible amount of work in trying to remove deprecations - anything in particular that I can look for being reduced - I just spent the last 20 minutes comparing a very short amount of time (<1 mins) of logs and I am having a hard time finding fewer deprecations - the files had 7800+ lines ;(
Love to help successfully test this! :) thx.
@bembelimen We tried to see the deprecation before, but failed. Perhaps it is easier you are doing 2nd code review?
I have tested this item ✅ successfully on 8461d6d
Tested with JBT, 'Log Deprecated API' enabled and calling Adminstrator > Users > User Actions Logs
- User Actions Logs are still working
- With Debug Bar
- Deprecations are reduced from 1'026 to 1'010
- With removing file
administrator/log/deprecated.phpbetween the testsgetDbo() is deprecatedreduced from 24 -> 23Joomla\CMS\Factory::getLanguage() is deprecatedreduced from 608 -> 593
Note: The deprecations are counted for Joomla\CMS\Factory by dependency injection, so we can not find them directly for the patches files.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45691.
I have tested this item ✅ successfully on 8461d6d
Reduced the number of deprecated messages visibly
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45691.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45691.
We would test this PR, but is the change in
tests/System/integration/install/Installation.cy.jsfile intended?