[#4569] - [Code Style] com_messages backend
- Closed
- 4 Dec 2014
- Medium
- Build: staging
- # 4569
- Diff
- phproberto:cs-com_messages-backend
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I think we need 2 tests on this because changes done in:
https://github.com/phproberto/joomla-cms/compare/joomla:staging...phproberto:cs-com_messages-backend?expand=1#diff-58d47869bc03e4659c4fa82975614951R28
It fixes the issues about params with no default values at the end of the parameter list on function definition. Same fix we applied in:
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/html/select.php#L157-L160
So the param is defined as optional but internally it's still required to ensure B/C
Votes
jissues-bot
- | Labels |
Added:
?
|
||
In fact I think that the default values of false for $canChange and 0 for row number are ok. I mean we could directly convert them into optional values without breaking anything.
I think we could remove the exceptions
I created JHtmlMessages::status() to replace the old JHtmlMessages::state(). Also added the log message and replaced the unique use we had on the message list view.
All should be B/C
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-12 17:19:24 |
| Title |
|
||||||
| Title |
|
||||||
| Status | Closed | ⇒ | New | ||||
I added the since tags 
javigomez
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Code style |
nicksavov
- | Labels |
Added:
?
|
||
ronakchauhan
- | Status | New | ⇒ | Pending |
Setting as a pending as we have fixes.
@test OK,
Tested sending and receiving messages between two users.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4569.
| Status | Pending | ⇒ | Ready to Commit |
Moving to RTC as we have 2 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4569.
| Labels |
Added:
?
|
||
Rebased vs the latest staging.
Merged, thanks!
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 2014-10-12 17:19:24 | ⇒ | 2014-12-04 07:25:47 |
| Labels |
Removed:
?
|
||
Would it make sense to deprecate the method and create a new one with the correct argument order?
This way we could add a deprecate log and change the extensions to use the new one already today and when we remove the method with 4.0 there are no issues.