RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
3 Jul 2025

Summary of Changes

Custom cache realizations can shard the cached files by subfolder within a usual cache group folder for file-based cache storage.

"Maintenance: Clear Cache" displays 0 as "Number of Files" and "Size" in this case.

We can easily implement recursive count of files and respect the subfolders for better statistics.

Clearing a cache group with subfolders already works.

Testing Instructions

Enable Joomla caching with File handler.

Create folder /administrator/cache/test and subfolders:

/administrator/cache/test/1
/administrator/cache/test/2

Create/copy any dummy files into these subfolders.

Actual result BEFORE applying this Pull Request

Open "Maintenance: Clear Cache", see test Cache Group with 0 files and size.

Expected result AFTER applying this Pull Request

See real number of files and size.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • Pull Request link for manual.joomla.org:
avatar Denitz Denitz - open - 3 Jul 2025
avatar Denitz Denitz - change - 3 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2025
Category Libraries
avatar muhme muhme - change - 9 Jul 2025
Labels Added: PR-5.4-dev
avatar sergeytolkachyov sergeytolkachyov - test_item - 11 Jul 2025 - Tested successfully
avatar sergeytolkachyov
sergeytolkachyov - comment - 11 Jul 2025

I have tested this item ✅ successfully on f7735c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45686.

avatar Denitz Denitz - change - 11 Jul 2025
Title
Respect subfolders of cached files in "Maintenance: Clear Cache" statistics
[5.4] Respect subfolders of cached files in "Maintenance: Clear Cache" statistics
avatar Denitz Denitz - edited - 11 Jul 2025
avatar exlemor exlemor - test_item - 11 Jul 2025 - Tested successfully
avatar exlemor
exlemor - comment - 11 Jul 2025

I have tested this item ✅ successfully on f7735c2

I have tested this successfully and with the Patch it does show 2 files for 27.72kb.

In case this is important, I would like to point out that I had 2 files one in folder 1 of 13kb and the other in folder 2 of 14.72kb and the BEFORE patch condition did show test folder - 1 file - 15kb and NOT 0 files as mentioned in the BEFORE test instructions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45686.

avatar richard67 richard67 - change - 11 Jul 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45686.

avatar brianteeman
brianteeman - comment - 11 Jul 2025

If your test does not match the instructions in the pr then it cannot be a successful test and/or the instructions are wrong and should be corrected.

@exlemor you complain when there are no instructions and ignore them when they exist. Both cannot be correct.

avatar muhme
muhme - comment - 11 Jul 2025

@exlemor Thanks for testing 👍 and thanks for commenting on your observations 👍 I will take them into account when retesting before merging.

avatar muhme
muhme - comment - 11 Jul 2025

I had 2 files one in folder 1 of 13kb and the other in folder 2 of 14.72kb and the BEFORE patch condition did show test folder - 1 file - 15kb and NOT 0 files as mentioned in the BEFORE test instructions

I assume the point (before applying this PR) is about sub-folders. Number and size for files in test/ are shown, but size 0 and number 0 is shown for files in sub-directories liketests/1/. Tested it is working with number of files and overall size in sub-directories.

avatar muhme muhme - change - 11 Jul 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-07-11 17:50:05
Closed_By muhme
Labels Added: RTC
avatar muhme muhme - close - 11 Jul 2025
avatar muhme muhme - merge - 11 Jul 2025
avatar muhme
muhme - comment - 11 Jul 2025

Many thanks @Denitz and all testers.

Add a Comment

Login with GitHub to post a comment