[#45678] - [5] Orphaned Ellipsis in Articles Module
- Fixed in Code Base
- 7 Aug 2025
- Medium
- Build: 5.3-dev
- # 45678
- Diff
- alikon:patch-26
User tests: Successful: Unsuccessful:
Pull Request for Issue #45665 .
Summary of Changes
fixed the truncateComplex method
Testing Instructions
set introtext to show
set Introtext Limit (characters)
create an article with more characters than Introtext Limit
publish the Articles module
Actual result BEFORE applying this Pull Request
Integer at diam ac nibh viverra vestibulum.
...
Expected result AFTER applying this Pull Request
Integer at diam ac nibh viverra vestibulum...
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
Unit/System Tests
|
||
| Title |
|
||||||
Tested this and had a good result
But: My screenreader seems to ignore the "...".
While I can see that this is a truncated text, the screeneader (NVDA on win11) reads a incomplete phrase.
Maybe someone with better screenreader skills can test that?
If my observation is correct, I suggest a sr-only information like "The following text is truncated" or whatever is convenient in this case.
This depends on the screen reader.
In particular, most screen readers have a number of punctuation settings such as "some", "most", and "all". So it depends which category the screen reader puts the ellipses character into, which punctuation setting the user has selected, and what action the user is taking.
It also depends if it is a fake ellipsis as used here (three dots) or a real ellipsis … or …
Maybe someone with better screenreader skills can test that?
If my observation is correct, I suggest a sr-only information like "The following text is truncated" or whatever is convenient in this case.
The read more button/link should act as the indicator that there is more text to follow and you dont need the sr-only information as that would be a double notification
It is the introtext, not the read more button.
It is the introtext, not the read more button.
Yes I know. The read more is the indication that there is more text.
I have tested this item ✅ successfully on 021a5aa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45678.
I have tested this item ✅ successfully on 021a5aa
I have succesfully tested this! (Thanks to Alikon, Christiane, Brian!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45678.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45678.
| Labels |
Added:
RTC
a11y
|
||
| Status | Ready to Commit | ⇒ | Pending |
Revert RTC, as it's a B/C break. We can't change type hinting in a bugfix version.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45678.
Revert RTC, as it's a B/C break. We can't change type hinting in a bugfix version.
@alikon For explanation: The above refers to the changes in line 157. Could you revert these changes? If this leads to new errors by phpstan, they can be added to the list of errors to be ignored (i.e. the phpstan-baseline.neon file) by running command phpstan -b. If necessary I can help with that.
| Labels |
Added:
b/c break
Removed: RTC |
||
The B/C break has been removed
The B/C break has been removed
Confirmed.
Are we supposed to re-test?
Are we supposed to re-test?
Yes, if possible, that would be great.
I have tested this item ✅ successfully on f348ead
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45678.
I have tested this item ✅ successfully on f348ead
I have retested this successfully. Thanks @alikon and everyone else involved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45678.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45678.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-07 09:44:17 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
bug
Removed: b/c break |
||
Thanks
the drone failure is unrelated to this pr (are about to the stats plugin), the Github Action CI are successfull