PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar conseilgouz
conseilgouz
1 Jul 2025

Pull Request for Issue #45653 .

Summary of Changes

During extension installation, when calling Installer, Database not set in Joomla\CMS\Installer\Installer error is displayed

Testing Instructions

Install an extension that calls Installer function, like https://www.joomlack.fr/en/joomla-extensions/page-builder-ck

Actual result BEFORE applying this Pull Request

Installation fails with Database not set in Joomla\CMS\Installer\Installer error

Expected result AFTER applying this Pull Request

Installation is OK

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar conseilgouz conseilgouz - open - 1 Jul 2025
avatar conseilgouz conseilgouz - change - 1 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2025
Category Libraries
avatar conseilgouz
conseilgouz - comment - 1 Jul 2025

Note : in J5.3, setDatabase was performed in Adapter construct function.
That's missing in the new Installer construct function.

avatar conseilgouz conseilgouz - change - 1 Jul 2025
Labels Added: PR-6.0-dev
avatar conseilgouz conseilgouz - change - 1 Jul 2025
The description was changed
avatar conseilgouz conseilgouz - edited - 1 Jul 2025
avatar conseilgouz
conseilgouz - comment - 1 Jul 2025

PR #43792 replaces parent::__construct call by its local calls. $this->db is missing from the new code.

avatar conseilgouz
conseilgouz - comment - 1 Jul 2025

In #43792, libraries/src/Console/ExtensionInstallCommande.php has 2 calls to Installer (line 151 and line 184).

I think that setDatabase lines (152 and 185) are not required anymore as this will be done in Installer.php construct function (if this PR is accepted).

Add a Comment

Login with GitHub to post a comment