RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
23 Jun 2025

Summary of Changes

Currently, if a page is loaded with task handling invalid controller, Joomla reports 500 server error status.

But logically, it should be a 404 response, but not a server error.

For instance, I have a custom notifier on server errors, but it's just an invalid URL, or it could be an old URL with menu item type changes. Once indexed by search engine, it will send you 500 errors.

Testing Instructions

Load any usual single article URL with appended invalid task like ?task=foo.bar, i.e.:

https://www.joomla.org/announcements/release-news/5928-joomla-5-3-1-bugfix-release.html?task=foo.bar

Actual result BEFORE applying this Pull Request

Invalid URL returns 500 status.

image

Expected result AFTER applying this Pull Request

Invalid URL returns 404 status.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar Denitz Denitz - open - 23 Jun 2025
avatar Denitz Denitz - change - 23 Jun 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2025
Category Libraries
avatar muhme muhme - test_item - 25 Jul 2025 - Tested successfully
avatar muhme
muhme - comment - 25 Jul 2025

I have tested this item ✅ successfully on 963fbd1


Tested with JBT, before applying this PR:

After applying the PR:

  • 404 Not Found
  • Also 404 Not Found for combined parameter first?catid=2&task=foo.bar
  • Other URL parameters still work: first?catid=2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45646.
avatar hans2103 hans2103 - test_item - 25 Jul 2025 - Tested successfully
avatar hans2103
hans2103 - comment - 25 Jul 2025

I have tested this item ✅ successfully on 963fbd1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45646.

Before

Screenshot 2025-07-25 at 20 23 23

After

Screenshot 2025-07-25 at 20 23 51
avatar richard67 richard67 - change - 25 Jul 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar richard67
richard67 - comment - 25 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45646.

avatar exlemor exlemor - test_item - 25 Jul 2025 - Tested successfully
avatar exlemor
exlemor - comment - 25 Jul 2025

I have tested this item ✅ successfully on 963fbd1

I have tested this successfully... thanks @Denitz!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45646.

avatar rdeutz rdeutz - change - 1 Aug 2025
Labels Added: RTC
avatar rdeutz rdeutz - change - 1 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-01 15:12:01
Closed_By rdeutz
avatar rdeutz rdeutz - close - 1 Aug 2025
avatar rdeutz rdeutz - merge - 1 Aug 2025

Add a Comment

Login with GitHub to post a comment