Feature RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
23 Jun 2025

Summary of Changes

Follow up for

PR removes use of the dispatcher argument from plugin constructors.

Testing Instructions

Code review.
Or
Check existing features works as before:
Create/edit Article
Create/edit Category
Create/edit custom field
Run Finder indexer
etc.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#419
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 23 Jun 2025
avatar Fedik Fedik - change - 23 Jun 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2025
Category Administration com_finder Front End Plugins
1ca187f 23 Jun 2025 avatar Fedik cs
avatar Fedik Fedik - change - 23 Jun 2025
Labels Added: Feature PR-5.4-dev
avatar muhme
muhme - comment - 9 Jul 2025

Thank you @Fedik for your PR, we would like to have this PR tested by humans in addition to the code review. Is it possible for you to extend the test instructions for human testers? This would give the testers the necessary setting.

avatar Fedik
Fedik - comment - 10 Jul 2025

we would like to have this PR tested by humans in addition to the code review

There is an info for this.

However it is not realistically to test ALL :)
Well, just review by a maintainer who know the topic, and merging in to upcoming Alpha would be good enough.

avatar exlemor
exlemor - comment - 13 Jul 2025

Hello @Fedik,

Tried to test this via the Patch Tester as there was no indication that this required an alternative approach like Download of a Pre-Built package, but came across an error in Red and the Patch would not apply:

The file marked for modification does not exist: plugins/sampledata/testing/services/provider.php

;( help. ;)

avatar brianteeman
brianteeman - comment - 13 Jul 2025

thats because there are conflicts that need to be resolved AND it includes changes in files that are not included in the distributed release such as everything in /tests

image
avatar ceford
ceford - comment - 22 Jul 2025

On my J5 test installation I get an error on applying the patch that mentions compat6:

The file marked for modification does not exist: plugins/behaviour/compat6/services/provider.php

So I tried on my J6 test installation, where I get:

The file marked for modification does not exist: plugins/behaviour/compat/services/provider.php

These are clones with the appropriate branch checked out and testing data installed.

These files do exist! What now?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45644.
avatar brianteeman
brianteeman - comment - 22 Jul 2025

How are you applying the patch?

avatar ceford
ceford - comment - 22 Jul 2025

With Patchtester

avatar brianteeman
brianteeman - comment - 22 Jul 2025

I doubt that you can use patchtester for this as there are too many files.

avatar exlemor exlemor - test_item - 1 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 1 Aug 2025

I have tested this item ✅ successfully on d2b3978

I have tested this successfully (via the Full Download package).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45644.

avatar richard67
richard67 - comment - 3 Aug 2025

@Fedik PHPstan fails due to some $plugin->setDispatcher($container->get(DispatcherInterface::class)) statements which you have added for b/c reason, I think:

Call to deprecated method setDispatcher() of class Joomla\Plugin\Editors\None\Extension\None:
5.2 will be removed in 7.0
             Plugin should implement DispatcherAwareInterface on its own, when it is needed.

I'm not sure if we should add new entries to the baseline file for that or if we better should add rules to the main config file like I did with my PR #45814 .

We should discuss that in the maintainers team.

avatar Fedik
Fedik - comment - 3 Aug 2025

I think we can add it to baseline.
This method is overriden in these plugins (I mean does not use CMSPlugin::setDispatcher() version) but PHPstan do not see it.

I will update it later.

avatar Fedik
Fedik - comment - 4 Aug 2025

@richard67 what did you made in other PR to fix phpstan?
I got the same problem again: locally runs fine but github job is crashing.
I tried clear-result-cache, but still the same

avatar richard67
richard67 - comment - 4 Aug 2025

@richard67 what did you made in other PR to fix phpstan? I got the same problem again: locally runs fine but github job is crashing. I tried clear-result-cache, but still the same

@Fedik I had compared the created baseline file with the one from a clean, current 5.4-dev branch and found one entry missing in the created one, so I have added that from the 5.4-dev branch. No idea why phpstan did not add it to the baseline file when creating it.

avatar richard67
richard67 - comment - 4 Aug 2025

@Fedik P.S.: I have no idea why entries from the 5.4-dev phpstan baseline file are missing when a branch of a PR is up to date with the 5.4-dev branch. Something is weird, but for sure it is not caused by your PR.

avatar Fedik
Fedik - comment - 4 Aug 2025

Seems works now, thanks!
Yea, something strange with that. Maybe something with different php versions

avatar HLeithner HLeithner - test_item - 19 Aug 2025 - Tested successfully
avatar HLeithner
HLeithner - comment - 19 Aug 2025

I have tested this item ✅ successfully on d2b3978

Full code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45644.

avatar richard67 richard67 - test_item - 22 Aug 2025 - Tested successfully
avatar richard67
richard67 - comment - 22 Aug 2025

I have tested this item ✅ successfully on d2b3978

Code review of all changes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45644.

avatar richard67 richard67 - change - 22 Aug 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45644.

avatar richard67 richard67 - change - 22 Aug 2025
Labels Added: RTC
avatar muhme
muhme - comment - 22 Aug 2025

✅ Final test before merge, with JBT graft

  • Enabled 'Debug System' and 'Log Almost Everything'
  • Created, featured and edited articles in backend; shown and edited in frontend
  • Created category and assigned to articles
  • Created custom fields text and colour, edited in backend and frontend
  • Running Smart Search > Index and Smart Search > Maintenance > Optimise / Clear Index
  • Created and edited contacts, uploaded images and assigned to contacts
  • Rotated, croped, resizes
  • Created Newsfeed, Created Feed Display module and placed on sidebar-right
  • Installed zitat-service.de module from JED Web, configured and placed on banner position
  • Tested language overwrite
  • Visited all tabs in System and Global Configuration, sent test email, cleared cache, updated database structure
  • Visited all tabs in user > edit profile
  • Hided or archived installation messages
  • Running through 'Welcome to Joomla!' guided tour, created a tag with guided tour
  • Tested logout from backend and frontend, tested remember me on frontend
  • Tested run tasks
  • Checked Joomla log files, checked PHP error log, found only one PHP warning (but, this source code file has not been changed):
[Fri Aug 22 12:23:59.972666 2025] [php:warn] [pid 106:tid 106] [client 192.168.65.1:21468] PHP Warning:  Undefined array key 0 in /var/www/html/libraries/src/Table/Nested.php on line 1335, referer: http://localhost:7054/administrator/index.php?option=com_content&view=article&layout=edit&id=2
avatar brianteeman
brianteeman - comment - 22 Aug 2025

@muhme there is a pr for that error from me.

avatar muhme muhme - change - 22 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-22 13:16:33
Closed_By muhme
avatar muhme muhme - close - 22 Aug 2025
avatar muhme muhme - merge - 22 Aug 2025
avatar muhme
muhme - comment - 22 Aug 2025

Thank you @Fedik for your contribution. Thank you @brianteeman and @ceford for suporting this PR. Thank you @exlemor, @HLeithner and @richard67 for testing/reviewing.

Add a Comment

Login with GitHub to post a comment