Thank you @Fedik for your PR, we would like to have this PR tested by humans in addition to the code review. Is it possible for you to extend the test instructions for human testers? This would give the testers the necessary setting.

we would like to have this PR tested by humans in addition to the code review

There is an info for this.

However it is not realistically to test ALL :)
Well, just review by a maintainer who know the topic, and merging in to upcoming Alpha would be good enough.

Hello @Fedik,

Tried to test this via the Patch Tester as there was no indication that this required an alternative approach like Download of a Pre-Built package, but came across an error in Red and the Patch would not apply:

The file marked for modification does not exist: plugins/sampledata/testing/services/provider.php

;( help. ;)

thats because there are conflicts that need to be resolved AND it includes changes in files that are not included in the distributed release such as everything in /tests

On my J5 test installation I get an error on applying the patch that mentions compat6:

The file marked for modification does not exist: plugins/behaviour/compat6/services/provider.php

So I tried on my J6 test installation, where I get:

The file marked for modification does not exist: plugins/behaviour/compat/services/provider.php

These are clones with the appropriate branch checked out and testing data installed.

These files do exist! What now?

How are you applying the patch?

With Patchtester

I doubt that you can use patchtester for this as there are too many files.

I have tested this item ✅ successfully on d2b3978

I have tested this successfully (via the Full Download package).

@Fedik PHPstan fails due to some $plugin->setDispatcher($container->get(DispatcherInterface::class)) statements which you have added for b/c reason, I think:

Call to deprecated method setDispatcher() of class Joomla\Plugin\Editors\None\Extension\None:
5.2 will be removed in 7.0
             Plugin should implement DispatcherAwareInterface on its own, when it is needed.

I'm not sure if we should add new entries to the baseline file for that or if we better should add rules to the main config file like I did with my PR #45814 .

We should discuss that in the maintainers team.

I think we can add it to baseline.
This method is overriden in these plugins (I mean does not use CMSPlugin::setDispatcher() version) but PHPstan do not see it.

I will update it later.

@richard67 what did you made in other PR to fix phpstan?
I got the same problem again: locally runs fine but github job is crashing.
I tried clear-result-cache, but still the same

@richard67 what did you made in other PR to fix phpstan? I got the same problem again: locally runs fine but github job is crashing. I tried clear-result-cache, but still the same

@Fedik I had compared the created baseline file with the one from a clean, current 5.4-dev branch and found one entry missing in the created one, so I have added that from the 5.4-dev branch. No idea why phpstan did not add it to the baseline file when creating it.

@Fedik P.S.: I have no idea why entries from the 5.4-dev phpstan baseline file are missing when a branch of a PR is up to date with the 5.4-dev branch. Something is weird, but for sure it is not caused by your PR.

Seems works now, thanks!
Yea, something strange with that. Maybe something with different php versions