RTC Language Change NPM Resource Changed PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Jun 2025

Pull Request for Issue #29564 .

Summary of Changes

This PR introduces a dedicated delete confirmation message for com_media instead of the global delete message.

The reason is to further clarify/warn that deleting a folder will delete all the contents of that folder. Unlike the generic message which just talks about deleting the selected item

Ideally I wanted to have a separate confirmation message for items and folders but this is not possible without significant rewrite and as no one has shown interest in that since the issue was first raised #29564 this PR is a small improvement.

Testing Instructions

To test you will need to either use a prebuilt package from this PR or apply the PR and then run npm i

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 20 Jun 2025
avatar brianteeman brianteeman - change - 20 Jun 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2025
Category Administration com_media NPM Change Language & Strings
avatar ChristineWk ChristineWk - test_item - 20 Jun 2025 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 20 Jun 2025

I have tested this item ✅ successfully on 15864b1

NPM Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45631.

avatar QuyTon QuyTon - test_item - 20 Jun 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 20 Jun 2025

I have tested this item ✅ successfully on 15864b1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45631.

avatar QuyTon QuyTon - change - 20 Jun 2025
Status Pending Ready to Commit
Labels Added: NPM Resource Changed Language Change PR-5.4-dev
avatar QuyTon
QuyTon - comment - 20 Jun 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45631.

avatar QuyTon QuyTon - change - 20 Jun 2025
Labels Added: RTC
avatar richard67
richard67 - comment - 24 Jun 2025

@brianteeman Is there a reason why we have different texts for frontend and backend?

avatar brianteeman
brianteeman - comment - 24 Jun 2025

Yes. My error. The admin language is the correct one. Will fix the other when I can get to a pc

avatar richard67
richard67 - comment - 24 Jun 2025

Yes. My error. The admin language is the correct one. Will fix the other when I can get to a pc

@brianteeman Thanks.

avatar brianteeman
brianteeman - comment - 24 Jun 2025

@richard67 fixed it

avatar richard67
richard67 - comment - 24 Jun 2025

I think it does not need new tests as I have just tested it successfully with the last 2 changes in administrator and site.

avatar richard67 richard67 - change - 24 Jun 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-06-24 21:31:46
Closed_By richard67
avatar richard67 richard67 - close - 24 Jun 2025
avatar richard67 richard67 - merge - 24 Jun 2025
avatar richard67
richard67 - comment - 24 Jun 2025

Thanks all (author and testers).

avatar brianteeman
brianteeman - comment - 24 Jun 2025

Thanks @richard67 for spotting my errors

Add a Comment

Login with GitHub to post a comment