? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
12 Oct 2014

Same as #4513 and #4514 but for content history

Content history is currently using mootools modal.
Without affecting in anyway the logic of the field we can use jQuery and bootstrap.

B/C
Should be 100% compatible

Testing:

Go to administrator -> Banners -> create a new banner
change the alternative text and save it again
repeat the last part for few more times

press the versions button
Everything should be ok

Before:
screenshot 2014-10-12 03 17 54

After:
screenshot 2014-10-12 03 17 04

avatar dgt41 dgt41 - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar dgt41 dgt41 - change - 12 Oct 2014
The description was changed
avatar dgt41
dgt41 - comment - 12 Oct 2014

Proposed title:
screenshot 2014-10-12 20 07 06

avatar dgt41 dgt41 - reference | 1052a5b - 12 Oct 14
avatar infograf768
infograf768 - comment - 13 Oct 2014

Why:

-       JHtml::_('behavior.modal', 'a.modal_jform_contenthistory');
-
+       JHtml::_('bootstrap.modal');
+
+       $lang = JFactory::getLanguage();
+       $extension = 'com_contenthistory';
+       $base_dir = JFactory::getApplication()->isAdmin() ? JPATH_ADMINISTRATOR : JPATH_SITE;
+       $language_tag = $lang->getName();
+       $reload = true;
+       $lang->load($extension, $base_dir, $language_tag, $reload);

which is anyway wrong as you should use $lang->getTag(); instead of $lang->getName();

avatar brianteeman brianteeman - change - 13 Oct 2014
Category Templates (admin) UI/UX
avatar infograf768
infograf768 - comment - 13 Oct 2014

Hmm, found out that we indeed have to reload language to get the modal title translated.
Not sure we need to check the $app and else as anyway the language file is only in admin
so we only need:

$lang = JFactory::getLanguage();
$lang->load('com_contenthistory', JPATH_ADMINISTRATOR, $lang->getTag(), true);
avatar Fedik
Fedik - comment - 13 Oct 2014

@dgt41 I am not guru, and for me jQuery("#userModal").modal("hide”); is good :smile:

another notice:
you use JHtmlBootstrap::renderModal
but better do it in Joomla! way JHtml::_('bootstrap.renderModal', $selector, $params , $footer)
example your:

JHtmlBootstrap::renderModal('versionsModal', array( 'url' => $link, 'title' => $label ,'height' => '600px', 'width' => '800px'), '');

will become:

JHtml::_('bootstrap.renderModal',  'versionsModal', array( 'url' => $link, 'title' => $label ,'height' => '600px', 'width' => '800px'));
avatar dgt41 dgt41 - reference | 71d22a3 - 13 Oct 14
avatar dgt41 dgt41 - reference | 0dcf2b9 - 14 Oct 14
avatar dgt41 dgt41 - change - 14 Oct 2014
The description was changed
avatar nicksavov nicksavov - change - 16 Oct 2014
The description was changed
Labels Added: ?
avatar zoom009 zoom009 - test_item - 17 Oct 2014 - Tested successfully
avatar trangredweb trangredweb - test_item - 17 Oct 2014 - Tested successfully
avatar trangredweb
trangredweb - comment - 17 Oct 2014

@test

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4561.

avatar mrunalpittalia
mrunalpittalia - comment - 17 Oct 2014

@tested Succesfullyscreen shot 2014-10-17 at 06 31 55

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4561.

avatar mrunalpittalia mrunalpittalia - test_item - 17 Oct 2014 - Tested successfully
avatar mrunalpittalia
mrunalpittalia - comment - 17 Oct 2014

moving to RTC as we have more that 2 successful tests

avatar mrunalpittalia mrunalpittalia - change - 17 Oct 2014
Status Pending Ready to Commit
avatar mrunalpittalia
mrunalpittalia - comment - 17 Oct 2014

moving to RTC as we have more than 2 successful tests

avatar RCheesley RCheesley - test_item - 17 Oct 2014 - Tested successfully
avatar dgt41
dgt41 - comment - 17 Oct 2014

The PRs regarding Media Field, User Field and Content History are also used in the front end. That might break the rendered design IF THE TEMPLATE is not BOOTSTRAP compatible. (the old modal uses it’s own css file). I wrote it!

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Ready to Commit Needs Review
avatar dgt41
dgt41 - comment - 17 Oct 2014

For B/C I reverted the option to use the mootools modal in front end. Lets NOT break every site out there.
Please test again

avatar dgt41 dgt41 - close - 19 Oct 2014
avatar dgt41 dgt41 - close - 19 Oct 2014
avatar dgt41 dgt41 - change - 19 Oct 2014
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2014-10-19 16:04:56
avatar dgt41
dgt41 - comment - 19 Oct 2014

Will try again when #3231 is committed

avatar dgt41 dgt41 - reference | ee6621e - 6 Nov 14
avatar dgt41 dgt41 - reference | ac35438 - 6 Nov 14
avatar dgt41 dgt41 - reference | 9d0aecf - 28 Dec 14
avatar dgt41 dgt41 - reference | 00485ef - 28 Dec 14
avatar dgt41 dgt41 - reference | 222b633 - 28 Dec 14
avatar dgt41 dgt41 - reference | 7516ca0 - 28 Dec 14
avatar dgt41 dgt41 - head_ref_deleted - 20 Jan 2015
avatar dgt41 dgt41 - reference | e3f037e - 12 Mar 15
avatar dgt41 dgt41 - reference | f6149e5 - 12 Mar 15

Add a Comment

Login with GitHub to post a comment