RTC Unit/System Tests PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
13 Jun 2025

Summary of Changes

Disables opcache in system tests as changes in the configuration file are not immediately reflected.

avatar laoneo laoneo - open - 13 Jun 2025
avatar laoneo laoneo - change - 13 Jun 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jun 2025
Category Unit Tests
avatar laoneo laoneo - change - 13 Jun 2025
Labels Added: Unit/System Tests PR-5.3-dev
avatar richard67
richard67 - comment - 13 Jun 2025

@laoneo Do we really have issues with opcache? I remember they were once solved in the filesystem library of the CMS, and after that we had no issues with it. After that, the CMS was changed to use the framework filesystem library and not the one from the CMS. However, the filesystem library is missing some of the changes from the CMS library. I have prepared a PR for that, see joomla-framework/filesystem#75 . It just needs some testing instructions. Maybe that could solve it?

avatar laoneo
laoneo - comment - 13 Jun 2025

This has nothing to do with the PHP filesystem code. To speed up the system tests, we write directly into the configuration.php file here. When we do an assertion afterwards, then it can be that still the old config from the opcache is loaded. That's why the SEF test here fails randomly, mostly on fast machines and works fine on slow ones.

avatar HLeithner
HLeithner - comment - 15 Jun 2025

Since this would break tests which require opcache testing I would suggest to disable opcache for this file:

add to the opcache.ini
opcache.blacklist_filename=/path/install/configure.php

avatar laoneo
laoneo - comment - 15 Jun 2025

Do we have any opcache tests? This disables it only for system tests.

avatar HLeithner
HLeithner - comment - 15 Jun 2025

if the issue is in opcache we wouldn't see it with the system tests if it's disabled like the reason you deactivate it, the tests, especially the system tests should be as near as possible as real setups right?

avatar heelc29 heelc29 - test_item - 16 Jun 2025 - Tested successfully
avatar heelc29
heelc29 - comment - 16 Jun 2025

I have tested this item ✅ successfully on f5ab6db

image
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45608.
avatar alikon alikon - test_item - 17 Jun 2025 - Tested successfully
avatar alikon
alikon - comment - 17 Jun 2025

I have tested this item ✅ successfully on f5ab6db


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45608.

avatar alikon alikon - change - 17 Jun 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 17 Jun 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45608.

avatar HLeithner HLeithner - change - 17 Jun 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-06-17 15:38:18
Closed_By HLeithner
Labels Added: RTC
avatar HLeithner HLeithner - close - 17 Jun 2025
avatar HLeithner HLeithner - merge - 17 Jun 2025
avatar HLeithner
HLeithner - comment - 17 Jun 2025

thanks

Add a Comment

Login with GitHub to post a comment