RTC bug RMDQ PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar travisrisner
travisrisner
12 Jun 2025

Pull Request for Issue #45567 .

Summary of Changes

This PR resolves an issue where values appended to a <limitbox> XML form field using the append attribute were incorrectly displayed with a J prefix (e.g., J35, J40, etc.) due to Joomla attempting to translate J{value} language keys that might not exist.

To fix this, the PR now checks if a language string exists for J{value} before applying the translation. If the key exists, it uses the translated text; otherwise, it uses the raw number as-is. This maintains compatibility with existing language strings while improving flexibility for custom use cases.

Testing Instructions

  1. Create a <field type="limitbox" append="35,36,37 /> in an XML form (or edit an existing form field if you don't want to create one, such as the limitbox field at administrator/components/com_users/forms/filter_groups.xml by adding the append attribute to it)
  2. Load the form and observe the dropdown options.
  3. Even though there is not going to be a language var for J35, J36, J37, instead of the dropdown showing a J prefixed entry for the text on the option, it just shows the raw text ( 35, 36, 37)

Actual result BEFORE applying this Pull Request

  • Options appended from append= show up with a J prefix, e.g., J35, J36, J37, even though these language keys likely don't exist.
  • Values are technically correct, but labels are confusing or incorrect.

Expected result AFTER applying this Pull Request

  • If a J{value} language key exists (like J25), it's translated.
  • If it doesn't exist, the raw value (e.g., 35) is used directly for the option label.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar travisrisner travisrisner - open - 12 Jun 2025
avatar travisrisner travisrisner - change - 12 Jun 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2025
Category Libraries
avatar travisrisner travisrisner - change - 12 Jun 2025
Labels Added: PR-5.3-dev
avatar exlemor exlemor - test_item - 25 Jul 2025 - Tested successfully
avatar exlemor
exlemor - comment - 25 Jul 2025

I have tested this item ✅ successfully on a691e2c

Hi Travis, great contribution! I was able to successfully test this. (took me a while to find/realize it was /administrator/index.php?option=com_users&view=groups that needed to be looking at with your recommended xml file update but eventually I did (and I didn't even AI :p lol )


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45598.

avatar travisrisner travisrisner - change - 25 Jul 2025
Labels Added: bug
avatar mothershedc mothershedc - test_item - 29 Jul 2025 - Tested successfully
avatar mothershedc
mothershedc - comment - 29 Jul 2025

I have tested this item ✅ successfully on d0b2175


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45598.

avatar rosslace rosslace - test_item - 29 Jul 2025 - Tested successfully
avatar rosslace
rosslace - comment - 29 Jul 2025

I have tested this item ✅ successfully on d0b2175


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45598.

avatar QuyTon QuyTon - change - 30 Jul 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 30 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45598.

avatar rdeutz
rdeutz - comment - 1 Aug 2025

I understand the idea here, but this would mean we are doing a special case just for this. Besides that, there is another way. If you want to add number to the limitbox, provide translations for it.

I have added the PR to ther agenda of the next possible Maintainers Meeting (13 Aug) - Stay tuned. :-)

avatar rdeutz rdeutz - change - 8 Aug 2025
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2025-08-08 09:08:18
Closed_By rdeutz
Labels Added: RTC RMDQ
avatar rdeutz rdeutz - close - 8 Aug 2025
avatar rdeutz
rdeutz - comment - 8 Aug 2025

We discussed it already. The decision was to leave it as it is. If you want to add more numbers to the limit box, you have to provide the translations, because that's how the system works. There are other numbering systems (Chinese and Persian Farsi), but we don't currently use any of them in the language packs. We could discuss whether it makes sense to translate numbers at all, but that is beyond the scope of this PR. I am therefore closing the PR. Thanks to all who worked on this.

Add a Comment

Login with GitHub to post a comment