PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Technicalleigh
Technicalleigh
10 Jun 2025

Pull Request for Issue # n/a

Summary of Changes

Fixes a regex to prevent double-slashes in the URLs for intro images used in RSS and Atom feeds

Testing Instructions

In the admin interface of a fresh Joomla installation:

  1. Admin: Open Menus > Main Menu and create a new menu item:
  • Title: test
  • Menu item type: Articles > Category List
  • Category: Uncategorised
  1. Admin: Create a new article:
  • Title: test page
  • Content: lorem ipsum
  • Intro image: /images/sampledata/cassiopeia/nasa1-1200.jpg
  1. Site: Click "test" in the Main Menu
  2. View page source to get the RSS or Atom feed URL
  3. Download the feed and open it in a text editor

Actual result BEFORE applying this Pull Request

<description><![CDATA[<p><img src="https://example.com//images/sampledata/cassiopeia/nasa1-1200.jpg" alt="" width="1200" height="400" loading="lazy"></p><p>lorem ipsum</p>]]></description>

Expected result AFTER applying this Pull Request

<description><![CDATA[<p><img src="https://example.com/images/sampledata/cassiopeia/nasa1-1200.jpg" alt="" width="1200" height="400" loading="lazy"></p><p>lorem ipsum</p>]]></description>

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Notes

I couldn't figure out why this happens for the Intro Image but not any other images in an article. I only happened to notice it because the RSS reader I use doesn't try to fix malformed URLs. :) I did some additional testing to ensure my fix doesn't interfere with any other links in the feed -- it looks good to me, but I'm no expert so please check closely.

Thank you for all your work on this project!

avatar Technicalleigh Technicalleigh - open - 10 Jun 2025
avatar Technicalleigh Technicalleigh - change - 10 Jun 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jun 2025
Category Libraries
avatar Technicalleigh Technicalleigh - change - 10 Jun 2025
The description was changed
avatar Technicalleigh Technicalleigh - edited - 10 Jun 2025
avatar Technicalleigh Technicalleigh - change - 24 Jul 2025
Labels Added: PR-5.3-dev
avatar exlemor
exlemor - comment - 1 Aug 2025

@Technicalleigh Hi there, I confirm that there is no double / thanks to your PR, but unfortunately for me on one of my test sites, it's not working 100%. I think it is perhaps because I am running Joomla from a sub-folder (one of my testing environments is setup as such on purpose)...

BEFORE PATCH:
https://www.mydomain.com/_j532//_j532/images/sampledata/cassiopeia/nasa1-1200.jpg

AFTER PATCH
https://www.mydomain.com/_j532/_j532/images/sampledata/cassiopeia/nasa1-1200.jpg

(but neither show the image of course even though what I expect:
https://www.mydomain.com/_j532/images/sampledata/cassiopeia/nasa1-1200.jpg does show the image).

Add a Comment

Login with GitHub to post a comment