User tests: Successful: Unsuccessful:
Pull Request for Issue # n/a
Fixes a regex to prevent double-slashes in the URLs for intro images used in RSS and Atom feeds
In the admin interface of a fresh Joomla installation:
<description><![CDATA[<p><img src="https://example.com//images/sampledata/cassiopeia/nasa1-1200.jpg" alt="" width="1200" height="400" loading="lazy"></p><p>lorem ipsum</p>]]></description>
<description><![CDATA[<p><img src="https://example.com/images/sampledata/cassiopeia/nasa1-1200.jpg" alt="" width="1200" height="400" loading="lazy"></p><p>lorem ipsum</p>]]></description>
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
I couldn't figure out why this happens for the Intro Image but not any other images in an article. I only happened to notice it because the RSS reader I use doesn't try to fix malformed URLs. :) I did some additional testing to ensure my fix doesn't interfere with any other links in the feed -- it looks good to me, but I'm no expert so please check closely.
Thank you for all your work on this project!
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
PR-5.3-dev
|
@Technicalleigh Hi there, I confirm that there is no double / thanks to your PR, but unfortunately for me on one of my test sites, it's not working 100%. I think it is perhaps because I am running Joomla from a sub-folder (one of my testing environments is setup as such on purpose)...
BEFORE PATCH:
https://www.mydomain.com/_j532//_j532/images/sampledata/cassiopeia/nasa1-1200.jpg
AFTER PATCH
https://www.mydomain.com/_j532/_j532/images/sampledata/cassiopeia/nasa1-1200.jpg
(but neither show the image of course even though what I expect:
https://www.mydomain.com/_j532/images/sampledata/cassiopeia/nasa1-1200.jpg does show the image).