bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
8 Jun 2025

Pull Request for Issue #45555 and #42196.

Summary of Changes

Fix date date format to use ISO 8601 (DateTime::ATOM) in in SchemaorgPrepareDateTrait.

Testing Instructions

  1. Create or edit an article.
  2. Enable structured data output using the Schema tab on the standard create article screen.
  3. Choose any schema type that has a date field in the form (e. g. Article).
  4. Use the built-in date picker to choose either a 'Date Created' or 'Date Modified' or both.
  5. Validate the page using a structured data testing tool.

https://search.google.com/test/rich-results

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar LadySolveig LadySolveig - open - 8 Jun 2025
avatar LadySolveig LadySolveig - change - 8 Jun 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2025
Category Libraries
avatar LadySolveig LadySolveig - change - 8 Jun 2025
The description was changed
avatar LadySolveig LadySolveig - edited - 8 Jun 2025
avatar LadySolveig LadySolveig - change - 9 Jun 2025
Labels Added: bug PR-5.3-dev
avatar LadySolveig LadySolveig - change - 9 Jun 2025
The description was changed
avatar LadySolveig LadySolveig - edited - 9 Jun 2025
avatar ceford ceford - test_item - 10 Jun 2025 - Tested successfully
avatar ceford
ceford - comment - 10 Jun 2025

I have tested this item ✅ successfully on 2a86f07

With the patch applied I see the output date change from "dateModified": "2025-06-10", to "dateModified": "2025-06-10T00:00:00+00:00", and the Rich Results report passes (apart from flagging a Breadcrumbs problem).

But I wonder if this is the right solution. Should we store and output the time?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45581.
avatar LadySolveig
LadySolveig - comment - 10 Jun 2025

@ceford I think that's a bit of a question of taste. But I think the date and the correct format are particularly relevant for the search engines.
I am completely neutral here and don't really have an opinion.
Thank you for testing 💚

avatar HLeithner HLeithner - change - 19 Jun 2025
The description was changed
avatar HLeithner HLeithner - edited - 19 Jun 2025

Add a Comment

Login with GitHub to post a comment