[#45575] - Set by default sef_ids to 1 in config.xml
- Closed
- 10 Jun 2025
- Medium
- Build: 5.3-dev
- # 45575
- Diff
- cyrez:patch-59
User tests: Successful: Unsuccessful:
Summary of Changes
On install, when dumping data for table #__extensions, the param sef_ids is set to 1.
For consistency, this PR also sets the default value of fields to 1 in config.xml for com_contact, com_content and com_newsfeeds.
Testing Instructions
Should not change anything on install nor update.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact com_content com_newsfeeds |
From memory this is not correct as the setting of 1 is only for new installs.
From memory this is not correct as the setting of 1 is only for new installs.
Maybe the reason was valid when there was still an option for legacy/modern routing?
Unfortunately this is not correct. If a site has been updated from Joomla 3 until today, the options of those components might not have been saved and thus there could be situations where these values aren't set at all. With this change, those sites would default to enable this feature, which until now would be disabled. That would change all URLs of those sites. Yes, it would be more consistent, but it would also be a break in b/c.
So my memory was correct
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-06-10 23:17:09 |
| Closed_By | ⇒ | cyrez | |
| Labels |
Added:
PR-5.3-dev
|
||
Thanks @brianteeman and @Hackwar
Ok, I see.
This means a possible B/C break from the J3 upgrade, only if people open the configuration and save without checking the new available options. This is probably not the majority, but it's what justifies me closing this PR, to avoid this possible problem.
So my memory was correct
"The true art of memory is the art of attention."
I have tested this item ✅ successfully on 843b990
Code review: I see the value is set to 1 in the installation sql scripts and is not set anywhere else in code (other than by the user). So it looks OK to me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45575.