RMDQ PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
29 May 2025

Pull Request for Issue #45496 .

Summary of Changes

As title says. As User I expect that After Content means "after the complete content" not "after intro text"

As this change affects all events "afterDisplayContent" not only custom fields, it should go into 6.0.

Testing Instructions

See issue #45496.

Actual result BEFORE applying this Pull Request

grafik

Custom fields are shown after the readmore text, but should be displayed after Content.

Expected result AFTER applying this Pull Request

Nothing is displayed after intro text.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 29 May 2025
avatar chmst chmst - change - 29 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2025
Category Front End com_content
avatar chmst chmst - change - 29 May 2025
The description was changed
avatar chmst chmst - edited - 29 May 2025
avatar chmst chmst - change - 29 May 2025
The description was changed
avatar chmst chmst - edited - 29 May 2025
avatar brianteeman
brianteeman - comment - 29 May 2025

This will have massive impacts on existing sites.

avatar chmst
chmst - comment - 29 May 2025

Yes. It is a very old bug, from the very first J4 version. We can say it is ok, people are used to it.
I let the decision to maintainers.

avatar brianteeman
brianteeman - comment - 29 May 2025

It is a opinion that it's a bug. Others will consider it as the intended behaviour. Either way changing it now will break existing sites.

avatar chmst
chmst - comment - 29 May 2025

Discussion here is a waste of time. As people seem to be used to the status quo, I close it.

avatar chmst chmst - change - 29 May 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-05-29 12:05:29
Closed_By chmst
Labels Added: RMDQ PR-6.0-dev
avatar chmst chmst - close - 29 May 2025
avatar wwwiiimmm
wwwiiimmm - comment - 30 May 2025

I know it's closed (too fast), as I don't think it's a waste.

Rather than removing events, add new events.
This way it has little to no impact on existing sites and adds flexibility for everyone.

Keep afterDisplayContent (on both intro and full).
Add two new events:

avatar chmst
chmst - comment - 30 May 2025

@wwwiiimmm thank you - this is a good idea.
But this too would affect all existing sites and overrides.

For me, the behaviour now is a bug,
Users can easily make overrides of the blog layout and use their own events, probably they do it already.

Would you like to make an own PR as an alternative for this one?

avatar chmst
chmst - comment - 13 Jun 2025

Re-opening and set to draft as there are different opinions if this is expected behaviour ora bug.

avatar chmst chmst - change - 13 Jun 2025
Status Closed New
Closed_Date 2025-05-29 12:05:29
Closed_By chmst
avatar chmst chmst - change - 13 Jun 2025
Status New Pending
avatar chmst chmst - reopen - 13 Jun 2025

Add a Comment

Login with GitHub to post a comment