Summary of Changes

build.php does not create zstd packages on macOS with default BSD tar:

In addition, the script does not stop in any environment if an error occurs, e.g. if zstd or the zip application is missing:

Building Joomla_5.3.1-Stable-Update_Package.zip... sh: 1: zip: not found

• Used is now separate piped tar and zstd calls, working in all environments, including macOS BSD-tar.
• Tested with (Intel-based):
  • macOS 15.5
  • Windows 11 WSL 2 Ubuntu 22.04
• For better readability, the shell commands are written without concatenations as one string.
• From my point of view every system() command should be check for error status and the script fail
  if a system commands fail. I can implement this in a follow-up PR. For example currently there is an
  to-be-ignored error:

  cp: build/fido.jwt: No such file or directory
  

Testing Instructions

1. If you have a Mac test the error before:

php build/build.php --remote=5.3.1

Actual result BEFORE applying this Pull Request

Building Joomla_5.3.1-Stable-Full_Package.tar.zst... tar: Couldn't open  zstd --ultra -22: No such file or directory

Expected result AFTER applying this Pull Request

2. After applying this PR full testing (including bz2) on macOS, Windows WSL 2 or Ubuntu native, 8 respective 4 archive files are created between 150 and 350 MB:

php build/build.php --remote=5.3.1 --include-bzip2
ls -l build/tmp/packages
php build/build.php --remote=5.3.1 --include-bzip2 --debug-build
ls -l build/tmp/packages

3. You can check that the script stops with hacking an error in

3.a Change zstd with zstdXXX in line 653:

php build/build.php --remote=5.3.1

You have to get something like:

Building Joomla_5.3.1-Stable-Full_Package.tar.zst... tar: Write error
failed.
ERROR: Command failed (127): tar --create * | zstdXXX --ultra -22 -o ../packages/Joomla_5.3.1-Stable-Full_Package.tar.zst
Output:
sh: zstdXXX: command not found

3.b Set packages directory file mode 0, inserting the chmod line after line 392 mkdir packages:

system('chmod 0 packages');

You have to get something like:

Building Joomla_5.3.1-Stable-Full_Package.zip ... failed.
ERROR: Command failed (15): zip -r ../packages/Joomla_5.3.1-Stable-Full_Package.zip *
Output:
zip I/O error: Permission denied
zip error: Could not create output file (../packages/Joomla_5.3.1-Stable-Full_Package.zip)

4. Unpack one package file and compare with previous build. Same number of files? Same file permissions?

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed