Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#45527] - [5.3] Debug duplicate queries dark mode

RTC NPM Resource Changed bug Dark Mode PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 May 2025

Pull Request for Issue #45084

Summary of Changes

Adds css for the display of duplicate queries in dark mode.
_(the line of css added is directly from upstream although for some reason I am not aware of or have time to look into we are not using directly)

Testing Instructions

enable debug and set your OS to dark mode (debugbar requires real dark mode not joomla's data-bs-theme=dark )
Visit any page with duplicate query eg site modules
Open debugbar and choose queries tab

as this is a css change you will need to test with either a prebuilt package or rebuild the css after applying the pr npm run build:css

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 25 May 2025
avatar brianteeman brianteeman - change - 25 May 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2025
Category ⇒ Repository NPM Change
avatar AkameOuO AkameOuO - test_item - 26 May 2025 - Tested successfully
avatar AkameOuO
AkameOuO - comment - 26 May 2025

I have tested this item ✅ successfully on 45a6b45
image

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45527.
avatar ceford ceford - test_item - 26 May 2025 - Tested successfully
avatar ceford
ceford - comment - 26 May 2025

I have tested this item ✅ successfully on 45a6b45

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45527.

avatar richard67
richard67 - comment - 26 May 2025

I would set RTC, but first the CSS code style errors which cause Drone to fail should be fixed by accepting my review suggestion.

@brianteeman Could you do that? Thanks in advance.

avatar brianteeman brianteeman - change - 26 May 2025
Labels Added: NPM Resource Changed bug Dark Mode PR-5.3-dev
avatar richard67 richard67 - alter_testresult - 26 May 2025 - AkameOuO: Tested successfully
avatar richard67 richard67 - alter_testresult - 26 May 2025 - ceford: Tested successfully
avatar richard67 richard67 - change - 26 May 2025
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 26 May 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45527.

avatar bembelimen bembelimen - change - 31 May 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-05-31 14:22:20
Closed_By ⇒ bembelimen
Labels Added: RTC
avatar bembelimen bembelimen - close - 31 May 2025
avatar bembelimen bembelimen - merge - 31 May 2025
avatar bembelimen
bembelimen - comment - 31 May 2025

Thx

Add a Comment

Login with GitHub to post a comment