RTC Release Blocker PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
24 May 2025

Pull Request for Issue # .

Follow up to PR #45371 .

Summary of Changes

With pull request (PR) #45371 the backwards compatibility (b/c) plugin for Joomla 6 from PR #45336 has been added to the 5.4-dev branch so that the plugin is already available and active on Joomla 5.4 when we update to Joomla 6.

This PR here completes that by making sure that the plugins' options are enabled on update to Joomla 6 so we can be sure a 3rd party system or behaviour plugin which will require these options on Joomla 6 does not cause the update to fail.

As the update SQL scripts modified by this PR have not been released yet we safely can change them.

Testing Instructions

Code review is sufficient.

Check that the params values changed by this PR here fits to the corresponding values in PR #45480 .

See e.g. here: https://github.com/joomla/joomla-cms/pull/45480/files#diff-3a9a51c74db65d66b70dbd56c86e63882cfaa26701ef6ff3f88bd0ea2682bb9fR265

But if you want to do a real test:

1. New installation

Make a new installation of the latest 5.4-dev nightly build to get the actual result, and make a new installation with the patched package created by Drone for this PR to get the expected result.

Then check the params value of the plg_behaviour_compat6 plugin in the #__extensions table.

2. Update

Update a 5.3.x or a recent 5.3-dev nightly build to the latest 5.4-dev nightly build to get the actual result, and update a 5.3.x or a recent 5.3-dev nightly build to the patched package created by Drone for this PR to get the expected result.

Then check the params value of the plg_behaviour_compat6 plugin in the #__extensions table.

Actual result BEFORE applying this Pull Request

After a new installation or an update from 5.3 or older, the plugin is added with params='{}'.

Expected result AFTER applying this Pull Request

After a new installation or an update from 5.3 or older, the plugin is added with params='{"classes_aliases":"1","legacy_classes":"1"}'.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 24 May 2025
avatar richard67 richard67 - change - 24 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2025
Category SQL Administration com_admin Postgresql Installation
avatar richard67 richard67 - change - 24 May 2025
The description was changed
avatar richard67 richard67 - edited - 24 May 2025
avatar bembelimen bembelimen - test_item - 25 May 2025 - Tested successfully
avatar bembelimen
bembelimen - comment - 25 May 2025

I have tested this item ✅ successfully on 44e1327


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525.

avatar LadySolveig LadySolveig - test_item - 25 May 2025 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 25 May 2025

I have tested this item ✅ successfully on 44e1327

Code Review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525.

avatar richard67 richard67 - change - 25 May 2025
Status Pending Ready to Commit
Labels Added: Release Blocker PR-5.4-dev
avatar richard67
richard67 - comment - 25 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45525.

avatar muhme muhme - change - 25 May 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-05-25 09:28:09
Closed_By muhme
Labels Added: RTC
avatar muhme muhme - close - 25 May 2025
avatar muhme muhme - merge - 25 May 2025
avatar muhme
muhme - comment - 25 May 2025

thxs all

Add a Comment

Login with GitHub to post a comment