[#4551] - File with two classes
- Closed
- 16 Oct 2014
- Medium
- Build: master
- # 4551
The file https://github.com/joomla/joomla-cms/blob/staging/administrator/includes/toolbar.php breaks the principle of having 1 class per file: JToolbarHelper and JSubMenuHelper
@chrisdavenport suggested that we could maybe fix it by removing JSubMenuHelper and including it from JToolbarHelper file. That way we will not break b/c. How does it sound?
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
+1
nicksavov
- | Labels |
Removed:
?
|
||
To test: If Joomla! Administrator home page loads - it works
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4551.
Pull request: https://github.com/joomla/joomla-cms/pull/4718/files
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4551.
Closing this now so that the conversation can continue at #4718 with the pull request - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4551.
zero-24
- | Status | New | ⇒ | Closed |
Set to "closed" on behalf of @brianteeman by The JTracker Application at issues.joomla.org/joomla-cms/4551
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-16 23:36:22 |
| Rel_Number | ⇒ | 4718 | |
| Relation Type | ⇒ | Related to |
| Labels |
Added:
?
|
||
I like it but suggest instead we just register the class name with the autoloader rather than doing a require_once or include_once from the helper file