No Code Attached Yet Release Blocker bug
avatar Elfangor93
Elfangor93
16 May 2025

Steps to reproduce the issue

  1. Prepare a local image filename (jpg) with a filename like name_20250516_1788636401.jpg
  2. Open the media manager in the Joomla backend
  3. Make sure, you are in the local - images filesystem adapter
  4. Upload the image file

Expected result

The file gets created.

Actual result

Nothing happens.

System information (as much as possible)

  • Joomla v6.0.0-alpha1-dev
  • Wampserver on Windows v3.3.0
  • PHP v8.1.13
  • MySQL 8.0.31

Additional comments

The error happens in

$name = $this->getSafeName($name);

The error that is thrown is Prohibited input U+0000005F

avatar Elfangor93 Elfangor93 - open - 16 May 2025
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2025
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 May 2025
avatar Elfangor93 Elfangor93 - change - 16 May 2025
The description was changed
avatar Elfangor93 Elfangor93 - edited - 16 May 2025
avatar MacJoom
MacJoom - comment - 16 May 2025

Confirmed - works in 5.3 and 5.4-dev

avatar MacJoom MacJoom - change - 16 May 2025
Labels Added: bug
avatar MacJoom MacJoom - labeled - 16 May 2025
avatar brianteeman
brianteeman - comment - 16 May 2025

it must be something todo with it having two underscore in the name

avatar brianteeman
brianteeman - comment - 16 May 2025

I believe that I have identified that the problem occurs within this step


        // Transform filename to punycode
         $name = PunycodeHelper::toPunycode($name);

Which is probably due to the major upgrade in algo26-matthias/idna-convert from 3.2 to 4.0

avatar Elfangor93
Elfangor93 - comment - 16 May 2025

From my point of view, underscores in filenames should not be a problem.

avatar brianteeman
brianteeman - comment - 16 May 2025

From my point of view, underscores in filenames should not be a problem.

agreed - itsa bug. I was just pointing out to developers where to look to resolve this

avatar MacJoom MacJoom - change - 16 Jun 2025
Labels Added: Release Blocker
avatar MacJoom MacJoom - labeled - 16 Jun 2025
avatar exlemor
exlemor - comment - 16 Jun 2025

Hi guys,

While most file systems support _ (underscores) as it is safe for filenames and widely accepted by most operations systems and applications, Google and Bing have been recommending for years for SEO purposes that you use hyphens (-) in URLs AND filenames that will be indexed by search engines (images, documents, web pages etc etc) and not to use _ (underscores) as Google and Bing treat hyphens (-) as word separators and do not do so for _ (underscores).

Since SEO is more important than ever, as Joomla, we should do everything we can to fix things like this that help with SEO.

avatar brianteeman
brianteeman - comment - 16 Jun 2025

Where is your evidence for that statement?

Even if true it is still a bug

avatar exlemor
exlemor - comment - 16 Jun 2025

Where is your evidence for that statement?

Even if true it is still a bug

Among many other sources:

From Google SEO Starter Guide:
https://developers.google.com/search/docs/fundamentals/seo-starter-guide ---> specifically:
https://developers.google.com/search/docs/crawling-indexing/url-structure

https://developers.google.com/style/filenames

https://www.youtube.com/watch?v=Tvd_5Is4F80
and https://www.safaridigital.com.au/blog/dash-vs-underscore-url-seo-best-practices/ and there are a plethora of sources that have discussed this topic over the last 10 years...

BUT the common thought is IF you have already written a file or URL with a _, you shouldn't just rewrite it to - to improve SEO (without doing a redirect).


No doubt that it is still a bug - you know better than I.

avatar brianteeman
brianteeman - comment - 16 Jun 2025

Interesting but ultimately irrelevant to the reported bug

avatar MacJoom
MacJoom - comment - 18 Jun 2025

We will not change underscores to hyphens and we will just fix the bug

avatar richard67 richard67 - change - 19 Jun 2025
Status New Closed
Closed_Date 0000-00-00 00:00:00 2025-06-19 14:23:15
Closed_By richard67
avatar richard67 richard67 - close - 19 Jun 2025
avatar richard67
richard67 - comment - 19 Jun 2025

Closing as having a pull request. Please test #45627 . Thanks in advance.

Add a Comment

Login with GitHub to post a comment