NPM Resource Changed PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
13 May 2025

Summary of Changes

When switching between light and dark mode in the backend template, you'll notice the sidebar contents moves by about 2px.
This is because a border is being applied only in dark mode.

This PR removes the border in dark mode as it's barely visible anyway.

Testing Instructions

  1. Run npm run build:css.
  2. Toggle between light/dark mode in the backend template.

Actual result BEFORE applying this Pull Request

Sidebar content layout shift

Expected result AFTER applying this Pull Request

No layout shift

avatar C-Lodder C-Lodder - open - 13 May 2025
avatar C-Lodder C-Lodder - change - 13 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2025
Category Repository NPM Change
avatar C-Lodder C-Lodder - change - 13 May 2025
The description was changed
avatar C-Lodder C-Lodder - edited - 13 May 2025
avatar QuyTon QuyTon - test_item - 13 May 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 13 May 2025

I have tested this item ✅ successfully on e35a86a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45469.

avatar brianteeman
brianteeman - comment - 15 May 2025

previous attempt did the same thing and was rejected #43161

avatar C-Lodder C-Lodder - change - 16 May 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-05-16 08:17:51
Closed_By C-Lodder
Labels Added: NPM Resource Changed PR-5.4-dev
avatar C-Lodder C-Lodder - close - 16 May 2025

Add a Comment

Login with GitHub to post a comment