[#45455] - [6.2] Add intro image to RSS feed item description in com_tags
- Pending
- Medium
- Build: 5.3-dev
- # 45455
- Diff
- keep:tag-feed-image
User tests: Successful: Unsuccessful:
Pull Request for Issue #44693
Summary of Changes
When generating a feed from com_tags, this change prepends the intro image (if available) to the feed item's description using an tag.
Testing Instructions
Create a tagged article that has an intro image.
Open the tag feed
Check that the feed item description starts with the intro image as an HTML element.
Actual result BEFORE applying this Pull Request
The feed item description contains only the article body text.
Expected result AFTER applying this Pull Request
If the article has an intro image, it is included before the description text in the feed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Labels |
Added:
PR-5.3-dev
|
||
I have tested this item 🔴 unsuccessfully on c3906ee
Getting an error, when trying to open the feed
0
Class "Joomla\Component\Tags\Site\View\Tag\HTMLHelper" not found
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45455.
This pull request has been automatically rebased to 5.4-dev.
This pull request has been automatically rebased to 6.1-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 6.2-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
Updates Requested
PR-6.2-dev
Removed: PR-5.3-dev |
||
When applied I got a server error.
When applied I got a server error.
I tested this during Happy Friday PR Testing session and while I was able to see a difference with the PR applied, I didn't get the image to be rendered as it gave an incorrect path to said image:
https://www.domain.com/_j62a/_j62a/images/banners/banner.jpg (error 404)
vs
https://www.domain.com/_j62a/images/banners/banner.jpg - image shows.
My Joomla 6.2 nightly dev installation is in a sub-folder, could that be the issue?
I have tested this item ✅ successfully on 17c7c52
Tested with JBT and Firefox with Livemarks RSS feed add-on
- Created two articles with intro images
- Before PR
- Article intro images are shown for category list RSS feed, but not for tagged articles RSS feed
- Applied PR with Patch Tester
- Article intro images are shown in tags RSS feed
- No unusual Joomla or PHP log messages
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45455.
I have tested this item ✅ successfully on 17c7c52
Tested with JBT and Firefox with Livemarks RSS feed add-on
- Created two articles with intro images
- Before PR
- Article intro images are shown for category list RSS feed, but not for tagged articles RSS feed
- Applied PR with Patch Tester
- Article intro images are shown in tags RSS feed
- No unusual Joomla or PHP log messages
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45455.
I have tested this item 🔴 unsuccessfully on c3906ee
I'm getting an error after applying the Patch:
Class "Joomla\Component\Tags\Site\View\Tag\HTMLHelper" not found
is an
use Joomla\CMS\HTML\HTMLHelper;
missing?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45455.