RTC b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
5 May 2025

Summary of Changes

Removes fetchExtensionCompatibility in UpdateController class as it is not used since

Testing Instructions

Install test sample data and browse around the front end and back end.

Actual result BEFORE applying this Pull Request

All is working.

Expected result AFTER applying this Pull Request

All is working.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#460

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 5 May 2025
avatar laoneo laoneo - change - 5 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2025
Category Administration com_joomlaupdate
avatar laoneo laoneo - change - 5 May 2025
The description was changed
avatar laoneo laoneo - edited - 5 May 2025
avatar laoneo laoneo - change - 5 May 2025
The description was changed
avatar laoneo laoneo - edited - 5 May 2025
avatar HLeithner
HLeithner - comment - 5 May 2025

can we please fix the camelCase for the batch function... it's not a b/c break and makes it constant to our code base and would be a good point in time before documentation

https://3v4l.org/bQHFu

avatar laoneo
laoneo - comment - 5 May 2025

I'm not sure if it is like that because of the task parameter in the url? Did you test it with the camelCase name?

avatar Bodge-IT
Bodge-IT - comment - 19 May 2025

@laoneo How would someone test this?

avatar laoneo
laoneo - comment - 19 May 2025

As this function is not used in core at all, there is nothing to test.

avatar laoneo
laoneo - comment - 19 May 2025

The closest you can do is to case insensitive search for the function name.

avatar laoneo laoneo - change - 21 May 2025
The description was changed
avatar laoneo laoneo - edited - 21 May 2025
avatar laoneo laoneo - change - 26 May 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-05-26 07:25:01
Closed_By laoneo
Labels Added: b/c break PR-6.0-dev
avatar laoneo laoneo - close - 26 May 2025
avatar rdeutz rdeutz - change - 28 May 2025
Status Closed New
Closed_Date 2025-05-26 07:25:01
Closed_By laoneo
avatar rdeutz rdeutz - change - 28 May 2025
Status New Pending
avatar rdeutz rdeutz - reopen - 28 May 2025
avatar ceford ceford - test_item - 30 May 2025 - Tested successfully
avatar ceford
ceford - comment - 30 May 2025

I have tested this item ✅ successfully on 2e596a8

Searched code for removed function and poked around in front end and back end. No problems.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436.

avatar muhme muhme - test_item - 30 May 2025 - Tested successfully
avatar muhme
muhme - comment - 30 May 2025

I have tested this item ✅ successfully on 2e596a8

Verified that the method is not used:

git clone https://github.com/joomla/joomla-cms -b 6.0-dev 60
# test before the PR
find 60 -name \*.php | xargs grep -i fetchExtensionCompatibility                                                  
60/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php:    public function fetchExtensionCompatibility()
60/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php:     * Called by controller's fetchExtensionCompatibility, which is called via AJAX.
# Apply the PR
gh pr checkout 45436
# Retest
find 60 -name \*.php | xargs grep -i fetchExtensionCompatibility
# nothing found :)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436.
avatar richard67 richard67 - change - 2 Jun 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Jun 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436.

avatar Bodge-IT Bodge-IT - change - 12 Jun 2025
Labels Added: RTC
avatar Bodge-IT Bodge-IT - change - 12 Jun 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-06-12 07:27:04
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 12 Jun 2025
avatar Bodge-IT Bodge-IT - merge - 12 Jun 2025
avatar Bodge-IT
Bodge-IT - comment - 12 Jun 2025

Thanks for the work @laoneo and thanks to @muhme & @ceford for time to test.

Add a Comment

Login with GitHub to post a comment