RTC Language Change PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
5 May 2025

Pull Request for Issue #44735 (comment) .

Summary of Changes

Adds title + visible text to the language switch button

Testing Instructions

Start the installation of Joomla! and check the language switch button.

Actual result BEFORE applying this Pull Request

Nothing visible

Expected result AFTER applying this Pull Request

New button text + aria-label:

image

// cc @brianteeman probably you could give feedback to the text and improve it when needed? Thx

avatar bembelimen bembelimen - open - 5 May 2025
avatar bembelimen bembelimen - change - 5 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2025
Category Installation Language & Strings
avatar bembelimen bembelimen - change - 5 May 2025
Title
[6.0] Add title + text to change language during installation
[6.0] Add title + text to change language button during installation
avatar bembelimen bembelimen - edited - 5 May 2025
avatar brianteeman
brianteeman - comment - 5 May 2025

You dont need the title= when you have visible text

avatar brianteeman
brianteeman - comment - 5 May 2025

I think you should do this the same as the readmore layout

so add aria-label to the button with the long text and the short text as visible

avatar bembelimen bembelimen - change - 5 May 2025
Labels Added: Language Change PR-6.0-dev
avatar bembelimen bembelimen - change - 5 May 2025
The description was changed
avatar bembelimen bembelimen - edited - 5 May 2025
avatar bembelimen bembelimen - change - 5 May 2025
Title
[6.0] Add title + text to change language button during installation
[6.0] Add aria-label + text to change language button during installation
avatar bembelimen bembelimen - edited - 5 May 2025
avatar brianteeman brianteeman - test_item - 5 May 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 May 2025

I have tested this item ✅ successfully on 020f2e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45430.

avatar QuyTon QuyTon - test_item - 5 May 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 5 May 2025

I have tested this item ✅ successfully on 020f2e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45430.

avatar QuyTon QuyTon - change - 5 May 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 5 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45430.

avatar softforge softforge - change - 7 May 2025
Labels Added: RTC
avatar softforge softforge - close - 7 May 2025
avatar softforge softforge - merge - 7 May 2025
avatar softforge softforge - change - 7 May 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-05-07 12:36:10
Closed_By softforge
avatar softforge
softforge - comment - 7 May 2025

Thank you @bembelimen for your speedy resolution of the issues raised and thanks to @brianteeman and @QuyTon for testing.

Add a Comment

Login with GitHub to post a comment