Feature PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
4 May 2025

Summary of Changes

The PR restores onBeforeExecute event for CMSApplication.
Originally added in #12124 and partialy removed in #27155

The PR depend on:

Testing Instructions

Apply both, PRs this and #40355 PR
Enable multi-language on testing site, and check it works.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 4 May 2025
avatar Fedik Fedik - change - 4 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2025
Category Libraries Front End Plugins
avatar Fedik Fedik - change - 4 May 2025
Labels Added: Feature PR-6.0-dev
avatar ceford ceford - test_item - 30 May 2025 - Tested successfully
avatar ceford
ceford - comment - 30 May 2025

I have tested this item ✅ successfully on 5de741c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45426.

avatar exlemor exlemor - test_item - 30 May 2025 - Tested successfully
avatar exlemor
exlemor - comment - 30 May 2025

I have tested this item ✅ successfully on 5de741c

I have tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45426.

avatar Fedik
Fedik - comment - 1 Jun 2025

@ceford @exlemor did you tested it with #40355 (as in description) right or?
I asking to be sure, because then we can set 2 PR as RTC. Thanks!

avatar exlemor
exlemor - comment - 1 Jun 2025

@ceford @exlemor did you tested it with #40355 (as in description) right or? I asking to be sure, because then we can set 2 PR as RTC. Thanks!

For myself, yes absolutely. :)

avatar ceford
ceford - comment - 1 Jun 2025

I just applied both patches again and looked at various frontend and backend pages in several languages. No problems. However, the testing instructions did not give any specific instructions on how to trigger the error and I have forgotten the details from the test I did two years ago.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45426.

avatar Fedik Fedik - change - 1 Jun 2025
Status Pending Ready to Commit
avatar Fedik
Fedik - comment - 1 Jun 2025

r2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45426.

avatar Fedik
Fedik - comment - 1 Jun 2025

A note for maintainers. This PR cannot be merged without:

Add a Comment

Login with GitHub to post a comment