RTC b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
28 Apr 2025

Summary of Changes

Does remove the call to stream_register in the BufferStreamHandler class outside of the class definition. If your extension relies on this, then call it before the logic.

Code review as this is only used in FTP client which is not used in core.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#452

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 28 Apr 2025
avatar laoneo laoneo - change - 28 Apr 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2025
Category Repository Libraries
avatar laoneo laoneo - change - 28 Apr 2025
The description was changed
avatar laoneo laoneo - edited - 28 Apr 2025
avatar brianteeman brianteeman - test_item - 28 Apr 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Apr 2025

I have tested this item ✅ successfully on b9b196d

code review only


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45402.

avatar HLeithner HLeithner - test_item - 28 Apr 2025 - Tested successfully
avatar HLeithner
HLeithner - comment - 28 Apr 2025

I have tested this item ✅ successfully on b9b196d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45402.

avatar laoneo laoneo - change - 28 Apr 2025
Labels Added: b/c break PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2025
Category Repository Libraries Libraries
avatar laoneo laoneo - change - 28 Apr 2025
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 28 Apr 2025

rtc as the only change in the last commit was to add the cs rules for camel case function names


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45402.

avatar softforge softforge - close - 28 Apr 2025
avatar softforge softforge - merge - 28 Apr 2025
avatar softforge softforge - change - 28 Apr 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-04-28 18:23:38
Closed_By softforge
Labels Added: RTC
avatar softforge
softforge - comment - 28 Apr 2025

Thank you @laoneo and the testers for your time and effort

Add a Comment

Login with GitHub to post a comment