RTC bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Apr 2025

Pull Request for Issue #45394 .

Summary of Changes

fix json

Testing Instructions

update from 5.2.3 or lower to a current Joomla version with postgresql

Actual result BEFORE applying this Pull Request

invalid json

Expected result AFTER applying this Pull Request

valid json

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 26 Apr 2025
avatar alikon alikon - change - 26 Apr 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2025
Category Postgresql SQL Administration com_admin
avatar QuyTon QuyTon - test_item - 27 Apr 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 27 Apr 2025

I have tested this item ✅ successfully on b9ffc52


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45395.

avatar heelc29
heelc29 - comment - 27 Apr 2025

This do not fix already broken sites.

avatar richard67
richard67 - comment - 27 Apr 2025

This do not fix already broken sites.

Correct.

@alikon Could you add a new update SQL script for PostgreSQL only with the right version and a suitable date, e.g. 5.3.1-2025-04-27.sql, which updates existing records with the wrong value? E.g.:

UPDATE "#__mail_templates"
 SET "params" = '{"tags":["messages","message","date","extension","username"]}'
 WHERE "template_id" = 'com_actionlogs.notification'
 AND "params" = '"tags":["messages","message","date","extension","username"]}';

As we are only checking for the complete "params" string, we can update the complete string without using any JSON functions. IF someone has already edited that mail template, if should fixed so the WHERE clause will not match.

avatar alikon alikon - change - 27 Apr 2025
Labels Added: PR-5.3-dev
avatar heelc29 heelc29 - test_item - 29 Apr 2025 - Tested successfully
avatar heelc29
heelc29 - comment - 29 Apr 2025

I have tested this item ✅ successfully on b912a2f

Update 4.4.13 to 5.3.0
image

Update 4.4.13/5.3.0 (broken) to this PR
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45395.
avatar richard67 richard67 - test_item - 1 May 2025 - Tested successfully
avatar richard67
richard67 - comment - 1 May 2025

I have tested this item ✅ successfully on b912a2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45395.

avatar richard67 richard67 - change - 1 May 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 1 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45395.

avatar richard67 richard67 - change - 1 May 2025
Labels Added: RTC bug
avatar laoneo laoneo - change - 6 May 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-05-06 12:07:05
Closed_By laoneo
avatar laoneo laoneo - close - 6 May 2025
avatar laoneo laoneo - merge - 6 May 2025
avatar laoneo
laoneo - comment - 6 May 2025

Thanks!

Add a Comment

Login with GitHub to post a comment