RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
24 Apr 2025

Summary of Changes

Follow up for #44516. The modified url should not be displayed after the update site is fetched as it can contain sensitive data. Better to assign the url to a new variable.

Testing Instructions

Add the following code to the file /plugins/installer/packageinstaller/src/Extension/PackageInstaller.php

public function onInstallerBeforeUpdateSiteDownload(\Joomla\CMS\Event\Installer\BeforeUpdateSiteDownloadEvent $event): void
{
        $event->updateUrl($event->getUrl().'demo=1');
}

and replace the line 47 with:

return ['onInstallerAddInstallationTab' => 'onInstallerAddInstallationTab', 'onInstallerBeforeUpdateSiteDownload' => 'onInstallerBeforeUpdateSiteDownload'];
  • Go to /administrator/index.php?option=com_installer&view=update
  • Click on "Check for updates"

Actual result BEFORE applying this Pull Request

The parameter demo=1 is shown in the warning message.
image

Expected result AFTER applying this Pull Request

The parameter demo=1 is not shown in the warning message.
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 24 Apr 2025
avatar laoneo laoneo - change - 24 Apr 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2025
Category Libraries
avatar laoneo laoneo - change - 3 May 2025
Labels Added: PR-5.3-dev
avatar dgrammatiko dgrammatiko - test_item - 3 May 2025 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 3 May 2025

I have tested this item ✅ successfully on 1197dd1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45373.

avatar alikon alikon - test_item - 3 May 2025 - Tested successfully
avatar alikon
alikon - comment - 3 May 2025

I have tested this item ✅ successfully on 1197dd1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45373.

avatar alikon alikon - change - 3 May 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 3 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45373.

avatar rdeutz rdeutz - change - 12 May 2025
Labels Added: RTC
avatar rdeutz rdeutz - change - 12 May 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-05-12 15:05:59
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 May 2025
avatar rdeutz rdeutz - merge - 12 May 2025
avatar rdeutz
rdeutz - comment - 12 May 2025

Thanks

Add a Comment

Login with GitHub to post a comment