User tests: Successful: Unsuccessful:
Follow up for #44516. The modified url should not be displayed after the update site is fetched as it can contain sensitive data. Better to assign the url to a new variable.
Add the following code to the file /plugins/installer/packageinstaller/src/Extension/PackageInstaller.php
public function onInstallerBeforeUpdateSiteDownload(\Joomla\CMS\Event\Installer\BeforeUpdateSiteDownloadEvent $event): void
{
$event->updateUrl($event->getUrl().'demo=1');
}
and replace the line 47 with:
return ['onInstallerAddInstallationTab' => 'onInstallerAddInstallationTab', 'onInstallerBeforeUpdateSiteDownload' => 'onInstallerBeforeUpdateSiteDownload'];
The parameter demo=1
is shown in the warning message.
The parameter demo=1
is not shown in the warning message.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
PR-5.3-dev
|
I have tested this item ✅ successfully on 1197dd1
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-05-12 15:05:59 |
Closed_By | ⇒ | rdeutz |
Thanks
I have tested this item ✅ successfully on 1197dd1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45373.