RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
17 Apr 2025

Summary of Changes

Currently, \Joomla\Component\Finder\Administrator\Helper\LanguageHelper::loadPluginLanguage() uses a database query to get list of available finder plugins and next loads their language files.

This database query is useless because we can use native PluginHelper::getPlugin('finder') method which provides additional benefit (no extra database query is executed).

Additionally, the language load should be performed using system-wide $extension key like plg_finder_content to prevent duplicate language file load.

This method is called in all com_finder views plus mod_finder display, we can remove extra database and prevent duplicate language load.

Testing Instructions

Apply patch. Test smart search views in frontend, check smart search module display.

Actual result BEFORE applying this Pull Request

See extra database query like

SELECT `name`,`element`
FROM `jos_extensions`
WHERE `type` = 'plugin' AND `folder` = 'finder' AND `enabled` = 1

Expected result AFTER applying this Pull Request

All views and module work as usual, no extra database query

Link to documentations

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar Denitz Denitz - open - 17 Apr 2025
avatar Denitz Denitz - change - 17 Apr 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2025
Category Administration com_finder
avatar Denitz Denitz - change - 17 Apr 2025
Labels Added: PR-5.3-dev
avatar Denitz Denitz - change - 17 Apr 2025
Title
Optimize load of smart search plugins language
[5.3] Optimize load of smart search plugins language
avatar Denitz Denitz - edited - 17 Apr 2025
avatar ceford
ceford - comment - 26 May 2025

With the patch applied I see that the quoted query disappears. However, in a page that has the query results and a query module I see the total number of queries increase! So, the patch is removing one query but creating more duplicates. Can you check and explain?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.

avatar Denitz
Denitz - comment - 2 Jun 2025

@ceford I can't confirm extra queries. Retested the patch and only see minus one query.

avatar ceford ceford - test_item - 2 Jun 2025 - Tested successfully
avatar ceford
ceford - comment - 2 Jun 2025

I have tested this item ✅ successfully on 38ef38b

I have rebuilt my test sites and tested this on the current 5 and 6 dev branches. I see the query disappear and I see no problems.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.

avatar QuyTon QuyTon - test_item - 4 Jun 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 4 Jun 2025

I have tested this item ✅ successfully on 38ef38b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.

avatar QuyTon QuyTon - change - 4 Jun 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 4 Jun 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.

avatar QuyTon QuyTon - change - 4 Jun 2025
Labels Added: RTC
avatar laoneo laoneo - change - 16 Jun 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-06-16 08:15:14
Closed_By laoneo
avatar laoneo laoneo - close - 16 Jun 2025
avatar laoneo laoneo - merge - 16 Jun 2025
avatar laoneo
laoneo - comment - 16 Jun 2025

Thanks!

Add a Comment

Login with GitHub to post a comment