User tests: Successful: Unsuccessful:
Currently, \Joomla\Component\Finder\Administrator\Helper\LanguageHelper::loadPluginLanguage()
uses a database query to get list of available finder plugins and next loads their language files.
This database query is useless because we can use native PluginHelper::getPlugin('finder')
method which provides additional benefit (no extra database query is executed).
Additionally, the language load should be performed using system-wide $extension
key like plg_finder_content
to prevent duplicate language file load.
This method is called in all com_finder views plus mod_finder display, we can remove extra database and prevent duplicate language load.
Apply patch. Test smart search views in frontend, check smart search module display.
See extra database query like
SELECT `name`,`element`
FROM `jos_extensions`
WHERE `type` = 'plugin' AND `folder` = 'finder' AND `enabled` = 1
All views and module work as usual, no extra database query
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_finder |
Labels |
Added:
PR-5.3-dev
|
Title |
|
I have tested this item ✅ successfully on 38ef38b
I have rebuilt my test sites and tested this on the current 5 and 6 dev branches. I see the query disappear and I see no problems.
I have tested this item ✅ successfully on 38ef38b
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-06-16 08:15:14 |
Closed_By | ⇒ | laoneo |
Thanks!
With the patch applied I see that the quoted query disappears. However, in a page that has the query results and a query module I see the total number of queries increase! So, the patch is removing one query but creating more duplicates. Can you check and explain?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.