RTC NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Apr 2025

This PR is an updated version of the PR first created by @crystalenka see #39266

Summary of Changes

Tree

  • Tree can not be collapsed
  • Long folder names are truncated
  • folder styling on focus as well as on hover (accessibility as you focus with a keyboard not hover)
  • If multiple filesystem plugins enabled then they are collapsible (can be tested with dpmedia and the pexels plugin)

Info

  • when a large number of images are in a folder the infobar is not visible without scrolling to the top

Testing Instructions

This will require either testing with a prebuilt package or run npm i

Actual result BEFORE applying this Pull Request

chrome_VZ2izWICpf.mp4

Expected result AFTER applying this Pull Request

chrome_RZYlazwzUf.mp4

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 14 Apr 2025
avatar brianteeman brianteeman - change - 14 Apr 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2025
Category Administration com_media NPM Change Repository
736fee1 14 Apr 2025 avatar brianteeman cs
avatar brianteeman brianteeman - change - 14 Apr 2025
Labels Added: NPM Resource Changed PR-5.3-dev
caf59a5 14 Apr 2025 avatar brianteeman cs
avatar richard67
richard67 - comment - 14 Apr 2025

This PR is an updated version of the PR first created by @crystalenka see #32966

@brianteeman Are you sure that it's the right issue? I think you meant #39266

avatar brianteeman brianteeman - change - 14 Apr 2025
The description was changed
avatar brianteeman brianteeman - edited - 14 Apr 2025
avatar brianteeman
brianteeman - comment - 14 Apr 2025

This PR is an updated version of the PR first created by @crystalenka see #32966

@brianteeman Are you sure that it's the right issue? I think you meant #39266

oops - typo - i fixed it

avatar Internetty
Internetty - comment - 17 Apr 2025

Hi there,
I just upgraded our site to Joomla 5.3.0 and tested the case again and it is still not fixed.

This is with reference to
#43713 (comment)

See screenrecording:
https://drive.google.com/file/d/1ge5TdRhKzj_ik98-kzihIpJaUuETGH0T/view?usp=sharing

We still cannot collapse the main media folder /images in the Media Manager
As you can see we have a quite long list of subfolders and there are issues when we are scrolling.

In addition we have a third party plugin to integrate Amazon AWS S3 external storage and when we scroll there is overlapping of local folder and Amazon AWS S3 folder.

Regards
Markus

avatar brianteeman
brianteeman - comment - 17 Apr 2025

it wont be fixed as no one has tested this proposed fix.

avatar QuyTon
QuyTon - comment - 25 Apr 2025

45320-border

In dark mode, please fix the white border.

avatar brianteeman
brianteeman - comment - 25 Apr 2025

that is not part of this PR. it has not been changed by this PR so I will not be changing it

before this pr

image

after this pr

image

avatar brianteeman
brianteeman - comment - 25 Apr 2025

It appears to be affected by this PR as it is not the case without this PR.

it looks identical before and after to me

I see it and fixed it on my alternate browser. Weird, sorry, it didnt show on my default browser

avatar brianteeman brianteeman - change - 25 Apr 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-04-25 21:03:09
Closed_By brianteeman
avatar brianteeman brianteeman - close - 25 Apr 2025
avatar brianteeman brianteeman - change - 28 Apr 2025
Status Closed New
Closed_Date 2025-04-25 21:03:09
Closed_By brianteeman
avatar brianteeman brianteeman - change - 28 Apr 2025
Status New Pending
avatar brianteeman brianteeman - reopen - 28 Apr 2025
5f27b69 28 Apr 2025 avatar brianteeman css
avatar QuyTon QuyTon - test_item - 7 May 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 7 May 2025

I have tested this item ✅ successfully on 5f27b69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45320.

avatar dautrich dautrich - test_item - 13 May 2025 - Tested successfully
avatar dautrich
dautrich - comment - 13 May 2025

I have tested this item ✅ successfully on 5f27b69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45320.

avatar alikon alikon - change - 13 May 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 13 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45320.

avatar rdeutz rdeutz - change - 13 May 2025
Labels Added: RTC
avatar rdeutz rdeutz - change - 13 May 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-05-13 11:53:31
Closed_By rdeutz
avatar rdeutz rdeutz - close - 13 May 2025
avatar rdeutz rdeutz - merge - 13 May 2025
avatar rdeutz
rdeutz - comment - 13 May 2025

Thanks

avatar brianteeman
brianteeman - comment - 13 May 2025

thanks and thanks to @crystalenka for doing most of the hard work - I just pushed it on its final steps

Add a Comment

Login with GitHub to post a comment