[#453] - Restore definition of DS.
User tests: Successful: Unsuccessful:
Wasn't DS supposed to be dropped?
Anyone can use the '/' now. And simply use DIRECTORY_SEPARATOR for the occasions you really need it.
Like sybrek: why?
Does this PR re-introduce a deprecated feature??
We decided that two lines of code to possibly save a lot of heartburn was
worth it. Am I missing something, or is there more to this? What is the
downside? Thanks. Mark
On Wed, Sep 26, 2012 at 1:23 PM, Seth Warburton notifications@github.comwrote:
Does this PR re-introduce a deprecated feature??
—
Reply to this email directly or view it on GitHub#453 (comment).
We've been saying for months now that the DS constant was going away with 3.0 and a lot of code hours went into removing its use from the CMS. It's been out of the master branch for several weeks now. The replacement is a PHP native solution available no matter what J! version being supported; use a slash or PHP's DIRECTORY_SEPARATOR constant. Restoring something at the 11th hour like this is causing the "WTF!?" reactions, and making some folks question whether their time spent working on this was worth it with it being back. Since it's in the 3.0 package, the constant must be supported until 4.0, or are we going to drop it in the middle of the release cycle?
OK. After further discussion, we have decided to remove DS as originally
planned. This has been committed to Github and will be in the final 3.0.0
packages.
Sorry about the confusion. The original process for deciding to remove it
was a good one, so I agree we shouldn't "panic" at the last minute.
Thanks. Mark
On Wed, Sep 26, 2012 at 4:49 PM, Michael Babker notifications@github.comwrote:
We've been saying for months now that the DS constant was going away with
3.0 and a lot of code hours went into removing its use from the CMS. It's
been out of the master branch for several weeks now. The replacement is a
PHP native solution available no matter what J! version being supported;
use a slash or PHP's DIRECTORY_SEPARATOR constant. Restoring something at
the 11th hour like this is causing the "WTF!?" reactions, and making some
folks question whether their time spent working on this was worth it with
it being back. Since it's in the 3.0 package, the constant must be
supported until 4.0, or are we going to drop it in the middle of the
release cycle?—
Reply to this email directly or view it on GitHub#453 (comment).
I just love debates/drama about single characters in code, they always deliver =)
Well I believe that one of those good things about GitHub is that it gives us a bit more transparency about what's going on. colored diffs and discussions - love it :)
IMHO the removed DS constant is one of those things that gives less headache to a dev when making an extension "fit" for the new Joomla! toys. Things like adding a Legacy postfix to classes hurt more..
It has also been well documented. See: Compatibility issues in Joomla 3.0 - General changes
The DS constant has been removed. If you really need it you can use DIRECTORY_SEPARATOR instead.
History can be verified ;)
So - please don't go back and forth.
Another +1 for not re-introducing a deprecated and removed feature.
To me
define('DS', DIRECTORY_SEPARATOR);
Just make my code shorter. I know that there is native PHP constant but I liked idea of DS. I would even add bunch of other shorts like
define('NL', "\n");
define('SP', " ");
define('BR', "<br />");
Since sometimes you have to add concatenation just to use those symbols.
"Well I believe that one of those good thing about GitHub is that it gives us a bit more transparency about what's going on. colored diffs and discussions - love it :)"
@elkuku I could not agree more.
I truly hope that one day all such changes happen in public like this. It can only be a huge benefit to the project to involve community devs like this. It's so much more human an experience than Joomlacode.
@dextercowley Thanks for taking community views into consideration so promptly and for reporting back here :)
@Serhioromano I'm not a coder, so the rights and wrongs of this are really lost on me. However, I am acutely aware than a helluva lot of people have spent a helluva lot of time removing DS from the CMS and from 3rd-party extensions, as it's deprecation was what was previously (and repeatedly) communicated. A last minute (really last second) reversal, without any public discussion, or even a description, would have been very frustrating to say the least.
why ?