Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4527] - [Code Style] com_users frontend

? ? Failure

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
11 Oct 2014

This fixes all the code style issues on com_users frontend.

This PR requires 2 tests as I've been forced to modify code:

https://github.com/phproberto/joomla-cms/compare/joomla:staging...phproberto:users-frontend?expand=1#diff-cd009ab48167c723aade8808e600cb79L166

Tests required

We need to check:

  • Users are able to save their profile in frontend and they are redirected correctly
  • On errors when editing the profile form the users are redirected back to the profile edit form

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00
avatar phproberto phproberto - open - 11 Oct 2014
avatar jissues-bot jissues-bot - change - 11 Oct 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 11 Oct 2014

Can you add what to test?

avatar phproberto
phproberto - comment - 12 Oct 2014

I added now the test instructions and now I'm going to review the since tags.

avatar roland-d
roland-d - comment - 12 Oct 2014

@test: Successful. User profile works as expected.

avatar roland-d roland-d - test_item - 12 Oct 2014 - Tested successfully
avatar javigomez javigomez - change - 13 Oct 2014
The description was changed
Title
…
[code style] com_users frontend
[Code Style] com_users frontend
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Oct 2014
Category ⇒ Code style
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar tumbigani tumbigani - test_item - 17 Oct 2014 - Tested successfully
avatar catanet
catanet - comment - 17 Oct 2014

@test
Environment: Joomla! 3.3.6 with test data loaded
Result: working, tested successfully

Note: the error message, when a mandatory field is not compiled, shows a : instead of a . at the end of the line.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4527.

avatar brianteeman
brianteeman - comment - 18 Oct 2014

@phproberto Is the report from @catanet releated to this PR or is it coming from elsewhere? Otherwise this van be set to RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4527.

avatar twsnikhil twsnikhil - test_item - 18 Oct 2014 - Tested successfully
avatar wilsonge
wilsonge - comment - 22 Oct 2014

Should be elsewhere. No lang strings are touched

avatar roland-d
roland-d - comment - 23 Oct 2014

Moving to RTC, 3 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4527.

avatar roland-d roland-d - change - 23 Oct 2014
Status Pending ⇒ Ready to Commit
avatar jissues-bot jissues-bot - change - 24 Oct 2014
Labels Added: ?
avatar phproberto
phproberto - comment - 24 Oct 2014

I added some since & deprecated tags.

I cannot merge my own PR. Feel free to merge after travis checks :dancer:

avatar Bakual
Bakual - comment - 24 Oct 2014

You broke Travis :p
I've restarted one job :)

avatar Bakual
Bakual - comment - 24 Oct 2014

Hmm,

fatal: Remote branch users-frontend not found in upstream origin

Do you hide your branch from Travis? :smile:

avatar phproberto
phproberto - comment - 24 Oct 2014

lol It's there! https://github.com/phproberto/joomla-cms/tree/users-frontend

Probably because I again pushed first to upstream, then deleted and then pushed to origin. :dash:

avatar Bakual
Bakual - comment - 24 Oct 2014

Merged into staging. Thanks!

avatar phproberto phproberto - close - 24 Oct 2014
avatar zero-24 zero-24 - close - 24 Oct 2014
avatar phproberto phproberto - change - 24 Oct 2014
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-24 13:08:13
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment