[#45265] - [5.3] Add method to allow get router object for CMSApplication
- Closed
- 3 Apr 2025
- Medium
- Build: 5.3-dev
- # 45265
- Diff
- joomdonation:get_router_object_for_cmsapplication
User tests: Successful: Unsuccessful:
Pull Request for Issue #44990, #45260.
Summary of Changes
Currently, the Router Service of our components is calling deprecated method getRouter to get router object. As the method was deprecated and will be removed in future Joomla releases, we should not use it's in new code introduced in Joomla 5.3.
The PR address that issue by adding adding new method getAppRouter() to get router object directly from application's container (instead of from global container like the deprecated method)
Testing Instructions
- Use Joomla 5.3 nightly build
- Follow the instructions at #44990, confirm the issue.
Actual result BEFORE applying this Pull Request
- Fatal error while access to a page that does not exist.
Expected result AFTER applying this Pull Request
- No fatal error, 404 not found is throw as expected.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content com_newsfeeds Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-04-03 08:09:06 |
| Closed_By | ⇒ | joomdonation |
It is not the same but Yes, it does not bring much improvement. Close the PR for now until we can find a better solution
Please just remove the deprecation for the getRouter() method and don't add the same method in green yet again.