Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#45261] - [5.3] Language switcher php deprecated notices

RTC RMDQ PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Apr 2025

Pull Request for Issue #43293 .

Summary of Changes

Fixes

  • Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Extension/ExtensionManagerTrait.php on line 45
  • Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in modules/mod_languages/src/Helper/LanguagesHelper.php on line 79

Testing Instructions

Make sure you are using php 8.1 or higher
Create a bilingual site
Create an instance of mod_languages in a position that exists also on an error page
In global configuration, set error reporting to maximum
Navigate to a url that will produce an error

Actual result BEFORE applying this Pull Request

two deprecated messages displayed

Expected result AFTER applying this Pull Request

No errors displayed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 1 Apr 2025
avatar brianteeman brianteeman - change - 1 Apr 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2025
Category ⇒ Libraries Modules Front End
avatar fgsw fgsw - test_item - 1 Apr 2025 - Tested successfully
avatar fgsw
fgsw - comment - 1 Apr 2025

I have tested this item ✅ successfully on a51f43c

Before PR

Screenshot 2025-04-01 at 10-45-28 Error 404

After PR

Screenshot 2025-04-01 at 10-46-55 Error 404

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45261.
avatar exlemor exlemor - test_item - 5 Apr 2025 - Tested successfully
avatar exlemor
exlemor - comment - 5 Apr 2025

I have tested this item ✅ successfully on a51f43c

I have tested this successfully. Thanks @brianteeman.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45261.

avatar bembelimen bembelimen - change - 7 Apr 2025
Status Pending ⇒ Ready to Commit
avatar bembelimen
bembelimen - comment - 7 Apr 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45261.

avatar joomdonation
joomdonation - comment - 7 Apr 2025

The right fix for the issue is #45262 . The change in this PR does not really fix the issue, it is just hiding the issue with our code elsewhere (for example, we should check and only call bootComponent if $component is not null instead, later, we can use string type for the parameter and let PHP throws the error if the passed argument is invalid). I suggest to close this PR.

avatar HLeithner HLeithner - close - 10 Apr 2025
avatar HLeithner
HLeithner - comment - 10 Apr 2025

We do not cast null to string (or ?? '') to make php happy, that's simple the wrong way to go, because there is a reason we get NULL. This should not happen and needs to be fixed, as tuan did in #45262

I'm closing this.

avatar HLeithner HLeithner - change - 10 Apr 2025
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-04-10 13:19:45
Closed_By ⇒ HLeithner
Labels Added: RTC RMDQ PR-5.3-dev
avatar brianteeman
brianteeman - comment - 10 Apr 2025

ok

Add a Comment

Login with GitHub to post a comment