RTC NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Mar 2025

Pull Request for Issue #45258.

Summary of Changes

The skip-to plugin when enabled on the frontend of your site has a css bug when displaying the keyboard shortcut

Testing Instructions

In the plugin setting for the skipto plugin make sure you enable it for both site and admin
In the front end tab to activate the plugin and hover to display the tooltip
image

If the text is longer than this (you're on a mac or using a different language) then the text is bigger than the background.

You can emulate this by creating a language string override for the string PLG_SYSTEM_SKIPTO_ACCESS_KEY in both site and admin so that you have a much longer string

As this is an scss change you will need to either run npm build:css or use a pre-built package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 31 Mar 2025
avatar brianteeman brianteeman - change - 31 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2025
Category Repository NPM Change
avatar fgsw fgsw - test_item - 1 Apr 2025 - Tested successfully
avatar fgsw
fgsw - comment - 1 Apr 2025

I have tested this item ✅ successfully on 1469953

Thanks @brianteeman.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45259.

avatar QuyTon QuyTon - test_item - 1 Apr 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 1 Apr 2025

I have tested this item ✅ successfully on 1469953


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45259.

avatar QuyTon QuyTon - change - 1 Apr 2025
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-5.3-dev
avatar QuyTon
QuyTon - comment - 1 Apr 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45259.

avatar tecpromotion tecpromotion - change - 17 Apr 2025
Labels Added: RTC
avatar tecpromotion tecpromotion - change - 17 Apr 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-04-17 14:24:35
Closed_By tecpromotion
avatar tecpromotion tecpromotion - close - 17 Apr 2025
avatar tecpromotion tecpromotion - merge - 17 Apr 2025
avatar brianteeman
brianteeman - comment - 17 Apr 2025

thanks

Add a Comment

Login with GitHub to post a comment