RTC NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hemang360
Hemang360
26 Mar 2025

Pull Request for Issue #44086.

Summary of Changes

  • Fixed an issue where the search bar description was partially visible

  • Changed bottom: 100% to top: 100%; bottom: auto;, ensuring the description appears completely without obstructing the search input.

Testing Instructions

  • Go to the media manager or any relevant page with a search bar.

  • Hover over the search bar to view the description tooltip.

  • Ensure the description appears below the search bar and does not overlap.

Actual result BEFORE applying this Pull Request

Screenshot 2025-03-27 004946

The description was partially visible.

Expected result AFTER applying this Pull Request

Screenshot 2025-03-27 005704
The description appears fully below the search bar.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hemang360 Hemang360 - open - 26 Mar 2025
avatar Hemang360 Hemang360 - change - 26 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2025
Category Repository NPM Change
avatar Hemang360 Hemang360 - change - 27 Mar 2025
Labels Added: NPM Resource Changed PR-5.2-dev
avatar brianteeman
brianteeman - comment - 27 Mar 2025

Nice work.

@richard67 @rdeutz I assume that this needs to be rebased to a different branch as there will be no further 5.2 releases. please can you let @Hemang360 know which branch that should be as I have no clue anymore as its so inconsistent

avatar tecpromotion
tecpromotion - comment - 28 Mar 2025

@Hemang360 please rebase your PR to the 5.3-dev branch. It will then probably come in 5.3.1.

avatar Hemang360
Hemang360 - comment - 28 Mar 2025

@tecpromotion @brianteeman I have rebased it to 5.3.

avatar richard67 richard67 - change - 28 Mar 2025
Title
[5.2] Fix description positioning in search bar
[5.3] Fix description positioning in search bar
avatar richard67 richard67 - edited - 28 Mar 2025
avatar QuyTon QuyTon - test_item - 1 Apr 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 1 Apr 2025

I have tested this item ✅ successfully on 8a8e643


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45229.

avatar fgsw fgsw - test_item - 1 Apr 2025 - Tested successfully
avatar fgsw
fgsw - comment - 1 Apr 2025

I have tested this item ✅ successfully on 8a8e643

For test used custom update server.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45229.

avatar QuyTon QuyTon - change - 1 Apr 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 1 Apr 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45229.

avatar Hemang360 Hemang360 - change - 13 Apr 2025
Labels Added: RTC
avatar Hemang360
Hemang360 - comment - 14 Apr 2025

Why I am seeing merging is blocked

avatar richard67
richard67 - comment - 14 Apr 2025

Why I am seeing merging is blocked

@Hemang360 Because the 5.3-dev branch is locked until we have released 5.3.0 stable tomorrow. After that, the branch will be unlocked again. Not related to your PR, and nothing you should worry about.

avatar Hemang360 Hemang360 - change - 15 Apr 2025
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2025-04-15 13:39:36
Closed_By Hemang360
Labels Added: PR-5.3-dev
Removed: PR-5.2-dev
avatar Hemang360 Hemang360 - close - 15 Apr 2025
avatar richard67
richard67 - comment - 15 Apr 2025

@Hemang360 Why have you closed this PR and deleted your fork of the repository?

avatar richard67
richard67 - comment - 15 Apr 2025

The pull request was ready to commit, which means it would be merged after the release when the branch would have been unlocked.

avatar Hemang360
Hemang360 - comment - 15 Apr 2025

@richard67 Sorry about that, I had opened the PR a long time ago and didn’t check back for a while. When I finally did, my fork was way behind and I was running into a lot of conflicts trying to sync it up. I tried resolving them, but things got messy and I thought the safest option would be to refork the repo from scratch.
I didn’t realize that would auto-close the PR...definitely my bad. I am opening a new PR with the same changes ASAP.

Apologies again for the trouble!

avatar Hemang360
Hemang360 - comment - 15 Apr 2025

Raised a new pull request #45325

Add a Comment

Login with GitHub to post a comment