[#45223] - [5.4] Fix Display of Deleted Users in User Notes
- Fixed in Code Base
- 14 Apr 2025
- Medium
- Build: 5.3-dev
- # 45223
- Diff
- AdarshSantoria:UserNotes
User tests: Successful: Unsuccessful:
Pull Request for Issue
Summary of Changes
In the User Notes view, the user_name field was displayed directly, but when a user was deleted, the field remained empty instead of indicating the deletion.
This PR updates the logic to check if user_name is empty and explicitly display "None" (JNONE) when the user has been deleted or the field is missing.
Testing Instructions
- Navigate to User Notes in Joomla Admin.
- Create a note for an existing user.
- Delete that user from the Users section.
- Before applying this PR:
- The
user_namefield appears blank in the User Notes table.
- The
- After applying this PR:
- The
user_namefield now correctly displays"None"(JNONE) when the associated user is deleted.
- The
Actual result BEFORE applying this Pull Request
- The User Notes table shows a blank
user_namefield when the associated user is deleted.
Expected result AFTER applying this Pull Request
- The User Notes table now displays
"None"(JNONE) when the associated user is deleted, ensuring clarity.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
I have tested this item ✅ successfully on 235089a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45223.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45223.
| Title |
|
||||||
| Labels |
Added:
RTC
PR-5.4-dev
|
||
As agreed today in the maintainers meeting, I've rebased this PR to 5.4-dev.
Should it not be distinguished when the user doesn't exist anymore or when the field is empty.
Should it not be distinguished when the user doesn't exist anymore or when the field is empty.
Hi @laoneo, since the user field is compulsory, a note can't exist without a user. So if user_id is present but no user is found, it means the user was deleted — that’s why we show JNONE. Would you suggest a better approach?
| Labels |
Added:
Updates Requested
Removed: PR-5.3-dev |
||
@brianteeman @ChristineWk With a quick retest from one of you I would leave this PR RTC and not require 2 new tests.
I have tested this item ✅ successfully on 38fcda1
latest change was purely cosmetic
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45223.
@brianteeman Thanks for retest.
@AdarshSantoria I've made the same change suggestion also for your other PR #45201 . Could you check that, too, and accept if ok? Thanks in advance.
@brianteeman Thanks for retest.
@AdarshSantoria I've made the same change suggestion also for your other PR #45201 . Could you check that, too, and accept if ok? Thanks in advance.
Thanks @richard67, checked and done!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-04-14 16:13:29 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Removed:
Updates Requested
|
||
@AdarshSantoria Thanks for this pull request, and thanks and congratulations for your other pull request, #45264 , which was the first one in this repository.
And thanks @ChristineWk and @brianteeman for testing.
I have tested this item ✅ successfully on 235089a
Good spot
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45223.