RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar AdarshSantoria
AdarshSantoria
26 Mar 2025

Pull Request for Issue

Summary of Changes

In the User Notes view, the user_name field was displayed directly, but when a user was deleted, the field remained empty instead of indicating the deletion.
This PR updates the logic to check if user_name is empty and explicitly display "None" (JNONE) when the user has been deleted or the field is missing.

Testing Instructions

  1. Navigate to User Notes in Joomla Admin.
  2. Create a note for an existing user.
  3. Delete that user from the Users section.
  4. Before applying this PR:
    • The user_name field appears blank in the User Notes table.
  5. After applying this PR:
    • The user_name field now correctly displays "None" (JNONE) when the associated user is deleted.

Actual result BEFORE applying this Pull Request

Screenshot (21)

  • The User Notes table shows a blank user_name field when the associated user is deleted.

Expected result AFTER applying this Pull Request

Screenshot (20)

  • The User Notes table now displays "None" (JNONE) when the associated user is deleted, ensuring clarity.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar AdarshSantoria AdarshSantoria - open - 26 Mar 2025
avatar AdarshSantoria AdarshSantoria - change - 26 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2025
Category Administration com_users
avatar AdarshSantoria AdarshSantoria - change - 26 Mar 2025
The description was changed
avatar AdarshSantoria AdarshSantoria - edited - 26 Mar 2025
avatar brianteeman brianteeman - test_item - 26 Mar 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Mar 2025

I have tested this item ✅ successfully on 235089a

Good spot


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45223.

avatar ChristineWk ChristineWk - test_item - 26 Mar 2025 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 26 Mar 2025

I have tested this item ✅ successfully on 235089a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45223.

avatar richard67 richard67 - change - 26 Mar 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar richard67
richard67 - comment - 26 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45223.

avatar richard67 richard67 - change - 26 Mar 2025
Title
[5.3] Fix Display of Deleted Users in User Notes
[5.4] Fix Display of Deleted Users in User Notes
avatar richard67 richard67 - edited - 26 Mar 2025
avatar richard67 richard67 - change - 26 Mar 2025
Labels Added: RTC PR-5.4-dev
avatar richard67
richard67 - comment - 26 Mar 2025

As agreed today in the maintainers meeting, I've rebased this PR to 5.4-dev.

avatar laoneo
laoneo - comment - 26 Mar 2025

Should it not be distinguished when the user doesn't exist anymore or when the field is empty.

avatar AdarshSantoria
AdarshSantoria - comment - 2 Apr 2025

Should it not be distinguished when the user doesn't exist anymore or when the field is empty.

Hi @laoneo, since the user field is compulsory, a note can't exist without a user. So if user_id is present but no user is found, it means the user was deleted — that’s why we show JNONE. Would you suggest a better approach?

avatar AdarshSantoria AdarshSantoria - change - 13 Apr 2025
Labels Added: Updates Requested
Removed: PR-5.3-dev
avatar richard67
richard67 - comment - 13 Apr 2025

@brianteeman @ChristineWk With a quick retest from one of you I would leave this PR RTC and not require 2 new tests.

avatar brianteeman brianteeman - test_item - 13 Apr 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Apr 2025

I have tested this item ✅ successfully on 38fcda1

latest change was purely cosmetic


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45223.

avatar richard67
richard67 - comment - 13 Apr 2025

@brianteeman Thanks for retest.

@AdarshSantoria I've made the same change suggestion also for your other PR #45201 . Could you check that, too, and accept if ok? Thanks in advance.

avatar richard67 richard67 - alter_testresult - 13 Apr 2025 - ChristineWk: Tested successfully
avatar AdarshSantoria
AdarshSantoria - comment - 14 Apr 2025

@brianteeman Thanks for retest.

@AdarshSantoria I've made the same change suggestion also for your other PR #45201 . Could you check that, too, and accept if ok? Thanks in advance.

Thanks @richard67, checked and done!

avatar richard67 richard67 - close - 14 Apr 2025
avatar richard67 richard67 - merge - 14 Apr 2025
avatar richard67 richard67 - change - 14 Apr 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-04-14 16:13:29
Closed_By richard67
Labels Removed: Updates Requested
avatar richard67
richard67 - comment - 14 Apr 2025

@AdarshSantoria Thanks for this pull request, and thanks and congratulations for your other pull request, #45264 , which was the first one in this repository.

And thanks @ChristineWk and @brianteeman for testing.

Add a Comment

Login with GitHub to post a comment