RTC Language Change PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Mar 2025

Pull Request for Issue #43872 .
This is a redo of #44243 that was unfortunately closed

Summary of Changes

When a new article is submitted on the front end of a site the notification email that is sent to admins will now use a mail template instead of plain text messages so that it can be customised and styled just as all other emails sent by Joomla. Currently its just a plain text email

Testing Instructions

Use a pre-built package or apply patch and the update sql
Make sure the admin user can receive emails from the test site
Create a new user with author rights
Go to the System Mail Templates and check that there is now a template "Content: New Article Submitted"
As the author Submit a new article on the front end
Check the email sent to the admin user

Actual result BEFORE applying this Pull Request

Plain text email sent AND joomla admin UI shows a new private message

Expected result AFTER applying this Pull Request

Email sent can be customised and no private message in the admin UI

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

acd0071 25 Mar 2025 avatar brianteeman oops
avatar brianteeman brianteeman - open - 25 Mar 2025
avatar brianteeman brianteeman - change - 25 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2025
Category Administration Language & Strings SQL Installation Postgresql Front End Plugins
avatar brianteeman brianteeman - change - 25 Mar 2025
Labels Added: Language Change PR-6.0-dev
avatar richard67
richard67 - comment - 25 Mar 2025

Does it need some update SQL script?

avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2025
Category Administration Language & Strings SQL Installation Postgresql Front End Plugins SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins
avatar brianteeman
brianteeman - comment - 25 Mar 2025

Sorry made a mess of the pr - should be ok now

avatar exlemor
exlemor - comment - 30 Mar 2025

Hi @brianteeman, tested your PR and it does what you are wanting it to but a couple of the language strings are not coming over as expected - please see screenshot here:

ScreenFloat Shot of Safari at Mar 30, 2025 at 3_25_07 PM

Thanks,

Emmanuel.

P.S.: I installed the Pre-built package in case that helps:
Joomla_6.0.0-alpha1-dev+pr.45211-Development-Update_Package.zip

avatar brianteeman
brianteeman - comment - 30 Mar 2025

@exlemor Should be ok now

avatar exlemor
exlemor - comment - 30 Mar 2025

@exlemor Should be ok now

Hi Brian, thanks, I assume that I need to wait for someone to rebuild the Pre-Built package as it is still one from 3+ hrs ago?

avatar richard67
richard67 - comment - 30 Mar 2025

@exlemor Should be ok now

Hi Brian, thanks, I assume that I need to wait for someone to rebuild the Pre-Built package as it is still one from 3+ hrs ago?

@exlemor The links to the download page and to the downloads contain the build number and so change after a new commit. Maybe you still were on the old download page?

Anyway, I've updated the branch, new downloads should be available soon.

avatar exlemor exlemor - test_item - 30 Mar 2025 - Tested successfully
avatar exlemor
exlemor - comment - 30 Mar 2025

I have tested this item ✅ successfully on 2934e92

I have tested this successfully and the language strings are fixed :). Thanks @brianteeman (and @richard67)!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45211.

avatar krishnaGandhi11 krishnaGandhi11 - test_item - 30 Mar 2025 - Tested successfully
avatar krishnaGandhi11
krishnaGandhi11 - comment - 30 Mar 2025

I have tested this item ✅ successfully on 2934e92

Tested successfully!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45211.

avatar krishnaGandhi11
krishnaGandhi11 - comment - 30 Mar 2025

I have tested this item ✅ successfully on 2934e92Tested successfully!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45211.

BEFORE Applying the PR:
Screenshot 2025-03-31 000954
Screenshot 2025-03-31 004617

AFTER Applying the PR:
Screenshot 2025-03-31 012418
Screenshot 2025-03-31 012347

avatar richard67 richard67 - change - 30 Mar 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 30 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45211.

avatar Bodge-IT Bodge-IT - change - 7 Apr 2025
Labels Added: RTC
avatar softforge softforge - merge - 7 Apr 2025
avatar softforge softforge - change - 7 Apr 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-04-07 18:44:45
Closed_By softforge
avatar softforge softforge - close - 7 Apr 2025
avatar softforge
softforge - comment - 7 Apr 2025

Thank you @brianteeman and the testers. It works nicely

Add a Comment

Login with GitHub to post a comment