Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4521] - JPagination fix: Wrong pagination when used a multiple instances

? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
11 Oct 2014

This pull fix the issue when a couple JPagination instances used.

Test
Run next code:

$p1 = new JPagination(10, 0, 5, 'pref1');
$data1 = $p1->getData();
$p2 = new JPagination(20, 0, 10, 'pref2');
$data2 = $p2->getData();
echo '<pre>';
print_r($data1->next);
print_r($data2->next);
echo '</pre>';

Result (before patch):

JPaginationObject Object
(
    [text] => Next
    [base] => 5
    [link] => /jdev/?pref1limitstart=5
    [prefix] => pref1
    [active] => 
)
JPaginationObject Object
(
    [text] => Next
    [base] => 5
    [link] => /jdev/?pref1limitstart=5
    [prefix] => pref1
    [active] => 
)

Expected result:

JPaginationObject Object
(
    [text] => Next
    [base] => 5
    [link] => /jdev/?pref1limitstart=5
    [prefix] => pref1
    [active] => 
)
JPaginationObject Object
(
    [text] => Next
    [base] => 10
    [link] => /jdev/?pref2limitstart=10
    [prefix] => pref2
    [active] => 
)
avatar Fedik Fedik - open - 11 Oct 2014
avatar jissues-bot jissues-bot - change - 11 Oct 2014
Labels Added: ?
avatar mbabker
mbabker - comment - 11 Oct 2014

@Fedik See Fedik#1

avatar Fedik Fedik - change - 11 Oct 2014
The description was changed
Title
…
JPagination fix, when used multiple instances
JPagination fix: Wrong pagination when used a multiple instances
avatar Fedik
Fedik - comment - 11 Oct 2014

@mbabker thanks!

avatar suredweb
suredweb - comment - 17 Oct 2014

@test It work!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4521.

avatar suredweb suredweb - test_item - 17 Oct 2014 - Tested successfully
avatar brianteeman brianteeman - change - 17 Oct 2014
Category ⇒ Libraries
avatar twssachin twssachin - test_item - 18 Oct 2014 - Tested successfully
avatar sagarch sagarch - test_item - 18 Oct 2014 - Tested successfully
avatar sagarch
sagarch - comment - 18 Oct 2014

Tested successfully(chrome)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4521.

avatar aniket19491 aniket19491 - test_item - 18 Oct 2014 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Oct 2014

Multiple good tests setting to RTc - thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4521.

avatar brianteeman brianteeman - change - 28 Oct 2014
Status Pending ⇒ Ready to Commit
avatar Bakual Bakual - close - 8 Nov 2014
avatar Bakual Bakual - change - 8 Nov 2014
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-11-08 13:50:42
avatar Bakual
Bakual - comment - 8 Nov 2014

Merged, thanks.
Solved a conflict in pagination.php manually.

avatar SPQRInc
SPQRInc - comment - 13 Jan 2015

Hi there,

this bugfix saved me a lot of work. But why isn't it on the latest Joomla release? I'm "up to date" and had to change the pagination.php manually.

It would be great if you could get this fix into the next Joomla release :-)

avatar brianteeman
brianteeman - comment - 13 Jan 2015

As you can see this was merged on Nov 8 and the last release was made 1st October. http://www.joomla.org/announcements/release-news/5569-joomla-3-3-6-released.html

So it will be in the next release (3.4) which hopefully is not too long away

avatar SPQRInc
SPQRInc - comment - 13 Jan 2015

Oh I did not see this. Alright, thanks a lot :-)

Add a Comment

Login with GitHub to post a comment