[#45200] - [6.0] Enable support for multiple image extensions in Random Image module
- Fixed in Code Base
- 12 Jun 2025
- Medium
- Build: 5.3-dev
- # 45200
- Diff
- AdarshSantoria:RandomImage
User tests: Successful: Unsuccessful:
Pull Request for Issue #45196
Summary of Changes
This pull request enhances the mod_random_image module by allowing the use of multiple image file extensions in the Image Type parameter. Previously, the module only supported a single extension like jpg. With this change, users can input comma-separated values (e.g., jpg,jpeg,png) to support multiple file types simultaneously.
Testing Instructions
- Prepare a folder with images of various formats such as
.jpg,.jpeg,.png, and.webp. - Create or edit a Random Image module and set the image folder to the one prepared above.
- In the Image Type field, enter values like
jpg,jpeg,png, or even uppercase likePNG. - Save the module and check the frontend display.
- Images with all the listed extensions should now appear randomly.
Actual result BEFORE applying this Pull Request
Only images with the exact extension specified (e.g., only jpg) were displayed.
Entering multiple extensions resulted in "No images" being shown.
Expected result AFTER applying this Pull Request
The module correctly loads and displays images of any extension listed in the comma-separated input (e.g., jpg,jpeg,png).
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
PR-5.3-dev
|
||
I like the idea behind it. As Joomla! 5.3 is in feature freeze mode, I move it to 5.4, so it can be tested there.
| Title |
|
||||||
| Labels |
Added:
Feature
PR-5.4-dev
|
||
I like the idea behind it. As Joomla! 5.3 is in feature freeze mode, I move it to 5.4, so it can be tested there.
shouldnt that be 6.0? When @HLeithner did the big rebase the other week all unmerged features were moved to 6
| Title |
|
||||||
| Category | Modules Front End | ⇒ | Administration com_templates com_users JavaScript Repository NPM Change External Library Composer Change Installation Libraries Modules Front End Plugins Unit Tests |
Rebased on 6.0
| Labels |
Added:
Unit/System Tests
Composer Dependency Changed
NPM Resource Changed
PR-6.0-dev
Removed: PR-5.3-dev |
||
Hi @seaoffate-net, Can you please test it.
I think this is a useful enhancement for Joomla and would improve flexibility for module users.
Would appreciate it if someone could review or test when possible. Thanks! 🙏
Hi
I have tried the update just now installed v5.30 i removed all but one of
the jpegs in the dir and uploaded a png to the folder
- images
https://www.seaoffate.net/administrator/index.php?option=com_media&path=local-images:/myimages/walking# - myimages
https://www.seaoffate.net/administrator/index.php?option=com_media&path=local-images:/myimages/walking# - walking
https://www.seaoffate.net/administrator/index.php?option=com_media&path=local-images:/myimages/walking#
so now i have just two images for the random picture to choose
from usedCoinSeaoffate512.png
and Dwarf_Walking-In_Woods_with_Dryads-1024.jpeg. if i refresh the page it
still only shows the jpeg. if i delete the jpeg it will not show the png.
ihave tried a few different .png files but they will not show. i have
deleted the .png and renamed a jpeg to jpg and on it's own it will not
display and not with others. i renamed the .jpg to jpeg and then it display.
This behaviour is not really a problem to me now that I know what it does
but I think it is not what is intended.so I alerted devs. please for my
part dont take any trouble to fix this as it is not a problem for me.
regards Nigel
On Tue, Mar 25, 2025 at 4:55 PM Adarsh Santoria @.***>
wrote:
Hi @seaoffate-net https://github.com/seaoffate-net, Can you please test
it.—
Reply to this email directly, view it on GitHub
#45200 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BQYWBDCUFEMBFBIXVQBRIML2WGDA3AVCNFSM6AAAAABZTOS5QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJRHEZTCMBSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>
[image: AdarshSantoria]AdarshSantoria left a comment
(#45200)
#45200 (comment)Hi @seaoffate-net https://github.com/seaoffate-net, Can you please test
it.—
Reply to this email directly, view it on GitHub
#45200 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BQYWBDCUFEMBFBIXVQBRIML2WGDA3AVCNFSM6AAAAABZTOS5QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJRHEZTCMBSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>
Hi @seaoffate-net, is the issue related to my changes? If yes, can you please attach images directly as your link requires login. Moreover, I think this is a good feature enhancement to add.
I have tested this item ✅ successfully on 170f8ee
A thought: would this work with SVG?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45200.
| Labels |
Removed:
PR-5.4-dev
|
||
| Category | Modules Front End Administration com_templates com_users JavaScript Repository NPM Change External Library Composer Change Installation Libraries Plugins Unit Tests | ⇒ | Modules Front End |
@ceford Could you repeat your test for this PR? When you had tested it, it had conflicts from a previous rebase. I just want to be sure it still works. It has to be tested on 6.0, e.g. a 6.0 nightly or with the patched package created for this PR by Drone. Thanks in advance.
I have tested this item ✅ successfully on e799d18
Confirmed using a new clone with Multilingual and Sample data installed. Random images included jpg, webp, png and bmp.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45200.
I have tested this item ✅ successfully on e799d18
I have successfully tested this PR. Thanks @AdarshSantoria!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45200.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45200.
| Labels |
Added:
RTC
Removed: Unit/System Tests Composer Dependency Changed NPM Resource Changed |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-06-12 12:38:42 |
| Closed_By | ⇒ | Bodge-IT |
Thanks for the change @AdarshSantoria and thanks to @exlemor, @ceford for persistent testing.
Hi @seaoffate-net, Can you please test it.