Feature Unit/System Tests Composer Dependency Changed NPM Resource Changed PR-6.0-dev PR-5.4-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar AdarshSantoria
AdarshSantoria
23 Mar 2025

Pull Request for Issue #45196

Summary of Changes

This pull request enhances the mod_random_image module by allowing the use of multiple image file extensions in the Image Type parameter. Previously, the module only supported a single extension like jpg. With this change, users can input comma-separated values (e.g., jpg,jpeg,png) to support multiple file types simultaneously.

Testing Instructions

  1. Prepare a folder with images of various formats such as .jpg, .jpeg, .png, and .webp.
  2. Create or edit a Random Image module and set the image folder to the one prepared above.
  3. In the Image Type field, enter values like jpg,jpeg,png, or even uppercase like PNG.
  4. Save the module and check the frontend display.
  5. Images with all the listed extensions should now appear randomly.
    Screenshot (13)
    Screenshot (14)

Actual result BEFORE applying this Pull Request

Only images with the exact extension specified (e.g., only jpg) were displayed.
Entering multiple extensions resulted in "No images" being shown.
Screenshot (15)

Expected result AFTER applying this Pull Request

The module correctly loads and displays images of any extension listed in the comma-separated input (e.g., jpg,jpeg,png).
Screenshot (12)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar AdarshSantoria AdarshSantoria - open - 23 Mar 2025
avatar AdarshSantoria AdarshSantoria - change - 23 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2025
Category Modules Front End
avatar AdarshSantoria AdarshSantoria - change - 23 Mar 2025
Labels Added: PR-5.3-dev
avatar AdarshSantoria
AdarshSantoria - comment - 25 Mar 2025

Hi @seaoffate-net, Can you please test it.

avatar bembelimen
bembelimen - comment - 25 Mar 2025

I like the idea behind it. As Joomla! 5.3 is in feature freeze mode, I move it to 5.4, so it can be tested there.

avatar bembelimen bembelimen - change - 25 Mar 2025
Title
[5.3] Enable support for multiple image extensions in Random Image module
[5.4] Enable support for multiple image extensions in Random Image module
avatar bembelimen bembelimen - edited - 25 Mar 2025
avatar bembelimen bembelimen - change - 25 Mar 2025
Labels Added: Feature PR-5.4-dev
avatar brianteeman
brianteeman - comment - 25 Mar 2025

I like the idea behind it. As Joomla! 5.3 is in feature freeze mode, I move it to 5.4, so it can be tested there.

shouldnt that be 6.0? When @HLeithner did the big rebase the other week all unmerged features were moved to 6

avatar HLeithner HLeithner - change - 26 Mar 2025
Title
[5.4] Enable support for multiple image extensions in Random Image module
[6.0] Enable support for multiple image extensions in Random Image module
avatar HLeithner HLeithner - edited - 26 Mar 2025
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2025
Category Modules Front End Administration com_templates com_users JavaScript Repository NPM Change External Library Composer Change Installation Libraries Modules Front End Plugins Unit Tests
avatar HLeithner
HLeithner - comment - 26 Mar 2025

Rebased on 6.0

avatar HLeithner HLeithner - change - 26 Mar 2025
Labels Added: Unit/System Tests Composer Dependency Changed NPM Resource Changed PR-6.0-dev
Removed: PR-5.3-dev
avatar AdarshSantoria
AdarshSantoria - comment - 7 Apr 2025

Hi @seaoffate-net, Can you please test it.

Add a Comment

Login with GitHub to post a comment